tests/sys/libc_newlib: drop test#21669
Merged
Enoch247 merged 1 commit intoRIOT-OS:masterfrom Aug 19, 2025
Merged
Conversation
This tests makes little sense to have for a number of reasons:
1. One should not use `iprintf()` for a number of reasons:
1. It is non-standard and using it over `printf()` makes the code
less portable (e.g. it cannot be used on AVR)
2. The idea of adding a leaner variant of `printf()` in addition to
the larger one is bogus, as apps will end up using both resulting
in a *larger* firmware instead of a smaller
3. RIOT's build system already has the `printf_float` module to
control whether formatting of floating point numbers should be
suppered. This mechanism will actually result in smaller builds,
if floating point support is not needed, as it prevents two
variants of printf to be linked in.
2. The test checks some implementation details (e.g. whether the
address of two functions is identical), rather than correct behavior
of the implementation. This is completely bogus.
Contributor
|
Was that test ever executed by our CI system? I don't think there is a test configuration which would set |
Member
Author
|
The boards that use newlib by default have a So this should indeed be executed. The fact that this fails in a PR that makes |
Enoch247
approved these changes
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This tests makes little sense to have for a number of reasons:
iprintf()for a number of reasons:printf()makes the code less portable (e.g. it cannot be used on AVR)printf()in addition to the larger one is bogus, as apps will end up using both resulting in a larger firmware instead of a smallerprintf_floatmodule to control whether formatting of floating point numbers should be suppered. This mechanism will actually result in smaller builds, if floating point support is not needed, as it prevents two variants of printf to be linked in.Testing procedure
Happy CI
Issues/PRs references
#9599 introduced this test.
As can be seen in the PR, the point of the test is to check whether using
nano.specsfrom newlib via the modulenewlib_nanohas the intended effect. But since it is up to whoever is building / packaging newlib to decide whether to provide anano.specsat all and how thenano.specsvariant is configured, this way of testing does not appear to be super valid.