makefiles/suit: add SUIT_GEN_PUBKEY variable to inhibit public key generation#21666
Merged
benpicco merged 1 commit intoRIOT-OS:masterfrom Sep 11, 2025
Merged
makefiles/suit: add SUIT_GEN_PUBKEY variable to inhibit public key generation#21666benpicco merged 1 commit intoRIOT-OS:masterfrom
SUIT_GEN_PUBKEY variable to inhibit public key generation#21666benpicco merged 1 commit intoRIOT-OS:masterfrom
Conversation
If we only have access the the public key, we don't want it to be accidentally overwritten by the build system. Intrudce a new `SUIT_GEN_PUBKEY` that defaults to 1, but can be set to 0 to disable auto-generating the public key from the private key (and generating a new private/public key pair if the private key does not exist).
benpicco
changed the title
SUIT_GEN_PUBKEY variable to inhibit pubkey gen
benpicco
added
Area: OTA
benpicco
changed the title
SUIT_GEN_PUBKEY variable to inhibit pubkey genSUIT_GEN_PUBKEY variable to inhibit public key generation
maribu
approved these changes
Aug 18, 2025
Contributor
|
It would be nice if you could add some documentation in the Doxygen generated SUIT documentation about this. Otherwise this may become a "hidden gem" that nobody else knows about and therefore nobody uses. |
Contributor
Author
|
Where would I add this? Just in |
Contributor
|
Since suit does not appear to have a |
fabian18
approved these changes
Aug 19, 2025
benpicco
commented
Aug 19, 2025
crasbe
added
Type: enhancement
Contributor
|
You didn't add the documentation yet :( |
Contributor
Author
|
I'll write a proper documentation for all those SUIT options in a separate PR 🤞 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
If we only have access the the public key, we don't want it to be accidentally overwritten by the build system.
Intrudce a new
SUIT_GEN_PUBKEYthat defaults to 1, but can be set to 0 to disable auto-generating the public key from the private key (and generating a new private/public key pair if the private key does not exist).Testing procedure
~/.local/share/RIOT/keys/default.pem(assumingdefault.pem.pubalready exists)examples/advanced/suit_updateexamples/advanced/suit_updatewithSUIT_GEN_PUBKEY=0Issues/PRs references