Merged
Conversation
This package seems to implement the [qDSA signature scheme][1], which seemed to not have received the level of attention and scrutiny from the crypto community one would expect before adopting it outside of lab environments and experiments. Hence, it might be better hosted on a repo that focuses exclusively on research, rather than in a repo of a general purpose OS that is intended to be used outside of lab environments as well. [1]: https://link.springer.com/chapter/10.1007/978-3-319-70697-9_10
maribu
requested review from
MichelRottleuthner,
aabadie,
jia200x and
leandrolanzieri
as code owners
maribu
added
CI: ready for build
github-actions
bot
added
Area: doc
Member
Author
|
This PR got announced in the forum and in the Matrix chat room to give people a chance to speak up if they want to keep the package. |
crasbe
added
the
Type: cleanup
crasbe
reviewed
Aug 13, 2025
Comment on lines
+255
to
+265
| ### pkg/qdsa [cc357f9638ce22a39eab8f79055f1154388ccb74] | ||
| Author(s): | ||
| - Kaspar Schleiser <[email protected]> (integration into RIOT as package) | ||
| - Joost Renes <[email protected]> (upstream code) | ||
|
|
||
| Reason for removal: | ||
| - No users besides the test | ||
| - The qDSA signature does not seem to have received the level of attention and | ||
| scrutiny by the crypto community that would justify inclusion in a general | ||
| purpose OS | ||
|
|
Contributor
There was a problem hiding this comment.
Why did you put that in the middle of the list?
Member
Author
There was a problem hiding this comment.
Isn't the list supposted to be alphabetically sorted?
Contributor
There was a problem hiding this comment.
It does not appear to be sorted alphabetically.
Contributor
There was a problem hiding this comment.
We can sort it alphabetically later. Looking at the Blame, it does not appear to have been in alphabetical order for a long time.
crasbe
approved these changes
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This package seems to implement the qDSA signature scheme, which seemed to not have received the level of attention and scrutiny from the crypto community one would expect before adopting it outside of lab environments and experiments.
Hence, it might be better hosted on a repo that focuses exclusively on research, rather than in a repo of a general purpose OS that is intended to be used outside of lab environments as well.
Testing procedure
Murdock will bark if anything still depended on the now deleted qDSA.
Issues/PRs references
None