boards: move licenses from headers to SPDX format (part4)#21632
boards: move licenses from headers to SPDX format (part4)#21632crasbe merged 3 commits intoRIOT-OS:masterfrom
Conversation
4229139 to
2251197
Compare
crasbe
left a comment
There was a problem hiding this comment.
You can probably keep all the cases that I flag in the review as test cases for the script. Considering how many more files there are to migrate, it would make sense to automate the script as much as possible.
3b1a9e7 to
32b6cd3
Compare
32b6cd3 to
f204ab2
Compare
|
Hmmm ... I'm not expert in CI - but it seams that there are problem with Murdock function BTW. I checked changed |
|
Probably. I looked once again at all changed files in this commit .... but not now :) |
|
I review twice all changes in the last "suspicious" commit - but all looks good (I suspect missing Only strange/other thing is double free line in the Original version of this "suspicious" commit is on my branch boards_change_to_SPDX_part4_last_commit. |
|
To find what exactly cause error in Murdock, I remove changes concerning SPDX headers for 33 files - which are part of sixth commit, which yesterday tests shows as cause of problems. Can be add this version of the PR to the merge queue? |
|
That works. |
dee5287 to
20500f3
Compare
|
Next attempt - I added 15 files with SPDX headers. |
|
This also works. |
20500f3 to
7086356
Compare
|
Next 10 files. |
7086356 to
d2b0993
Compare
|
Now it seams OK. I prepare next test ;) |
|
Hmmm ... I (probably) have suspect - |
|
That also works. Perhaps you can clean up the commits and we merge it as it is now. Also, there is a typo in one (or two) of the commits: "wich" instead of "which". And also there is a missing whitespace after "boards:" in one of the commits. Furthermore, you can probably squash the Silicon Labs and SAM commits with the "starting with s" commit. |
|
@crasbe Thanks for help with this very long PR ;) I cleaned commits names and squashed all commits for boards which starts for s - Silicon Labs, SAM and seeeduino. I hope this time PR finally merge. |
Contribution description
This PR moves license information from headers to SPDX format for boards which names starts with letter q to z.
This is almost end for
boarddirectory (*).@crasbe sorry for (little) more than 200 files.
Except detection of missing Copyright keyword #21515 (comment) and some strange #21515 (comment), which was fixed manually, other work is done automatically using scripts described in PR #21515.
(*) There are some missing Copyrights in
doc.txtanddoc.mdfiles, I will move them in once, when I move all files to thedoc.mdformat.Testing procedure
Review changed files.
Issues/PRs references
Track #21515