Skip to content

boards: move licenses from headers to SPDX format (part4)#21632

Merged
crasbe merged 3 commits intoRIOT-OS:masterfrom
krzysztof-cabaj:boards_change_to_SPDX_part4
Aug 20, 2025
Merged

boards: move licenses from headers to SPDX format (part4)#21632
crasbe merged 3 commits intoRIOT-OS:masterfrom
krzysztof-cabaj:boards_change_to_SPDX_part4

Conversation

@krzysztof-cabaj
Copy link
Copy Markdown
Contributor

Contribution description

This PR moves license information from headers to SPDX format for boards which names starts with letter q to z.
This is almost end for board directory (*).

@crasbe sorry for (little) more than 200 files.

Except detection of missing Copyright keyword #21515 (comment) and some strange #21515 (comment), which was fixed manually, other work is done automatically using scripts described in PR #21515.

(*) There are some missing Copyrights in doc.txt and doc.md files, I will move them in once, when I move all files to the doc.md format.

Testing procedure

Review changed files.

Issues/PRs references

Track #21515

@github-actions github-actions bot added Area: boards Area: Board ports Area: Kconfig Area: Kconfig integration labels Jul 30, 2025
@krzysztof-cabaj krzysztof-cabaj force-pushed the boards_change_to_SPDX_part4 branch from 4229139 to 2251197 Compare July 30, 2025 15:29
@crasbe crasbe added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs labels Jul 30, 2025
@riot-ci
Copy link
Copy Markdown

riot-ci commented Jul 30, 2025

Murdock results

✔️ PASSED

222175d boards: move licenses to SPDX for boards which name's start from t-z

Success Failures Total Runtime
1 0 1 02m:41s

Artifacts

Copy link
Copy Markdown
Contributor

@crasbe crasbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can probably keep all the cases that I flag in the review as test cases for the script. Considering how many more files there are to migrate, it would make sense to automate the script as much as possible.

@krzysztof-cabaj krzysztof-cabaj force-pushed the boards_change_to_SPDX_part4 branch 3 times, most recently from 3b1a9e7 to 32b6cd3 Compare July 30, 2025 17:44
@crasbe crasbe enabled auto-merge July 30, 2025 18:42
@crasbe crasbe added this pull request to the merge queue Jul 30, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 30, 2025
@crasbe crasbe added this pull request to the merge queue Jul 30, 2025
@crasbe crasbe removed this pull request from the merge queue due to a manual request Jul 30, 2025
@crasbe crasbe added this pull request to the merge queue Jul 30, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 30, 2025
@krzysztof-cabaj krzysztof-cabaj force-pushed the boards_change_to_SPDX_part4 branch from 32b6cd3 to f204ab2 Compare July 31, 2025 07:34
@crasbe crasbe added this pull request to the merge queue Jul 31, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 31, 2025
@krzysztof-cabaj
Copy link
Copy Markdown
Contributor Author

Hmmm ... I'm not expert in CI - but it seams that there are problem with Murdock function get_supported_boards .

BTW. I checked changed Kconfig files and except this one in the board directory, which I fixed today, all other are OK.

@krzysztof-cabaj
Copy link
Copy Markdown
Contributor Author

Probably. I looked once again at all changed files in this commit .... but not now :)

@krzysztof-cabaj
Copy link
Copy Markdown
Contributor Author

I review twice all changes in the last "suspicious" commit - but all looks good (I suspect missing #pragma once or config in Kconfig file).

Only strange/other thing is double free line in the boards/zigduino/Kconfig.
I fix this and pushed.

Original version of this "suspicious" commit is on my branch boards_change_to_SPDX_part4_last_commit.

@crasbe crasbe enabled auto-merge August 19, 2025 08:55
@crasbe crasbe added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Aug 19, 2025
@crasbe crasbe added this pull request to the merge queue Aug 19, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 19, 2025
@krzysztof-cabaj
Copy link
Copy Markdown
Contributor Author

To find what exactly cause error in Murdock, I remove changes concerning SPDX headers for 33 files - which are part of sixth commit, which yesterday tests shows as cause of problems.

Can be add this version of the PR to the merge queue?

@crasbe crasbe added this pull request to the merge queue Aug 20, 2025
@crasbe crasbe removed this pull request from the merge queue due to a manual request Aug 20, 2025
@crasbe
Copy link
Copy Markdown
Contributor

crasbe commented Aug 20, 2025

That works.

@krzysztof-cabaj krzysztof-cabaj force-pushed the boards_change_to_SPDX_part4 branch from dee5287 to 20500f3 Compare August 20, 2025 09:54
@krzysztof-cabaj
Copy link
Copy Markdown
Contributor Author

Next attempt - I added 15 files with SPDX headers.

@crasbe crasbe added this pull request to the merge queue Aug 20, 2025
@crasbe crasbe removed this pull request from the merge queue due to a manual request Aug 20, 2025
@crasbe
Copy link
Copy Markdown
Contributor

crasbe commented Aug 20, 2025

This also works.

@krzysztof-cabaj krzysztof-cabaj force-pushed the boards_change_to_SPDX_part4 branch from 20500f3 to 7086356 Compare August 20, 2025 10:48
@krzysztof-cabaj
Copy link
Copy Markdown
Contributor Author

Next 10 files.

@crasbe crasbe enabled auto-merge August 20, 2025 10:49
@crasbe crasbe added this pull request to the merge queue Aug 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 20, 2025
@krzysztof-cabaj krzysztof-cabaj force-pushed the boards_change_to_SPDX_part4 branch from 7086356 to d2b0993 Compare August 20, 2025 10:59
@crasbe crasbe enabled auto-merge August 20, 2025 10:59
@krzysztof-cabaj
Copy link
Copy Markdown
Contributor Author

Now it seams OK. I prepare next test ;)

@krzysztof-cabaj
Copy link
Copy Markdown
Contributor Author

Hmmm ... I (probably) have suspect - boards/Kconfig. I try add all without this.

@crasbe
Copy link
Copy Markdown
Contributor

crasbe commented Aug 20, 2025

That also works. Perhaps you can clean up the commits and we merge it as it is now.

Also, there is a typo in one (or two) of the commits: "wich" instead of "which". And also there is a missing whitespace after "boards:" in one of the commits.

Furthermore, you can probably squash the Silicon Labs and SAM commits with the "starting with s" commit.

@krzysztof-cabaj
Copy link
Copy Markdown
Contributor Author

@crasbe Thanks for help with this very long PR ;)

I cleaned commits names and squashed all commits for boards which starts for s - Silicon Labs, SAM and seeeduino.

I hope this time PR finally merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: boards Area: Board ports Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants