Skip to content

dist/tools: Move picosdk to pkg folder, improve picotool.sh script#21629

Merged
crasbe merged 2 commits intoRIOT-OS:masterfrom
crasbe:pr/picosdk_pkg
Aug 1, 2025
Merged

dist/tools: Move picosdk to pkg folder, improve picotool.sh script#21629
crasbe merged 2 commits intoRIOT-OS:masterfrom
crasbe:pr/picosdk_pkg

Conversation

@crasbe
Copy link
Copy Markdown
Contributor

@crasbe crasbe commented Jul 29, 2025 •
edited
Loading

Contribution description

The picosdk is required for the RP2350 support #21545 and it would be convenient to use it through the USEPKG mechanism.

TODO: I think I removed too much from the picotool Makefile. The picotool has to be built for the RP2040 as well, but that does not use the picosdk.
Fixed.

Ping @AnnsAnns :)
I decided it would be easier if I create a separate PR (I'll send you a modified patch later for your PR), see the TODO...

Testing procedure

Make sure BOARD=rpi-pico make -C tests/minimal flash still works.

Issues/PRs references

Requirement for #21545.

@crasbe crasbe requested a review from Teufelchen1 July 29, 2025 20:27
@crasbe crasbe added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jul 29, 2025
@github-actions github-actions bot added Area: pkg Area: External package ports Area: tools Area: Supplementary tools labels Jul 29, 2025
@riot-ci
Copy link
Copy Markdown

riot-ci commented Jul 29, 2025 •
edited
Loading

Murdock results

✔️ PASSED

0ee6a62 dist/tools: update link to picotool doc, add wildcard for udev rule

Success Failures Total Runtime
10547 0 10547 12m:11s

Artifacts

@crasbe crasbe removed the State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet label Jul 29, 2025
@crasbe crasbe mentioned this pull request Jul 29, 2025
Merged
@crasbe
Copy link
Copy Markdown
Contributor Author

crasbe commented Jul 29, 2025

TODO: Update the warning message about the udev rules because the picotool repository changed their README.
Also perhaps add a hint where to find said udev rules.

TODO: Use the opportunity to update to picotool 2.2.0, that was released today.

@crasbe
Copy link
Copy Markdown
Contributor Author

crasbe commented Jul 29, 2025

TODO: Update the warning message about the udev rules because the picotool repository changed their README. Also perhaps add a hint where to find said udev rules.

The script already printed the path where to find the rules. However, the latest release changed the name of the udev rule. So when we update the picotool, the shell script is already fit for it.

TODO: Use the opportunity to update to picotool 2.2.0, that was released today.

I decided against that and will postpone it until after the RP2350 support is merged to avoid breaking something with the update.

@crasbe crasbe changed the title dist/tools: Move picosdk to pkg folder dist/tools: Move picosdk to pkg folder, improve picotool.sh script Jul 29, 2025
@AnnsAnns
Copy link
Copy Markdown
Member

AnnsAnns commented Jul 30, 2025

The goat at it again 👍

Teufelchen1
Teufelchen1 reviewed Jul 31, 2025
View reviewed changes
@Teufelchen1
Copy link
Copy Markdown
Contributor

Teufelchen1 commented Jul 31, 2025

Just squash it man.. :p

@AnnsAnns
Copy link
Copy Markdown
Member

AnnsAnns commented Jul 31, 2025

Hooray

@crasbe crasbe enabled auto-merge July 31, 2025 11:13
@crasbe crasbe disabled auto-merge July 31, 2025 11:14
@crasbe
Copy link
Copy Markdown
Contributor Author

crasbe commented Jul 31, 2025

No point in adding this to the merge queue yet until the Cryptocell issue is fixed 🫠

@crasbe crasbe enabled auto-merge July 31, 2025 21:26
@crasbe crasbe added this pull request to the merge queue Jul 31, 2025
Merged via the queue into RIOT-OS:master with commit a0f5197 Aug 1, 2025
25 checks passed
@crasbe crasbe deleted the pr/picosdk_pkg branch August 3, 2025 12:54
@benpicco benpicco added this to the Release 2025.10 milestone Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Teufelchen1 Teufelchen1 Teufelchen1 approved these changes

Assignees

No one assigned

Labels

Area: pkg Area: External package ports Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

Release 2025.10

Development

Successfully merging this pull request may close these issues.

5 participants

@crasbe @riot-ci @AnnsAnns @Teufelchen1 @benpicco