driver/motor_driver: fix failing motor initialization#21626
Merged
maribu merged 1 commit intoRIOT-OS:masterfrom Jul 28, 2025
Merged
driver/motor_driver: fix failing motor initialization#21626maribu merged 1 commit intoRIOT-OS:masterfrom
maribu merged 1 commit intoRIOT-OS:masterfrom
Conversation
`pwm_init` returns the actual frequency the pwm is set to, not the exact frequency requested.
benpicco
added
the
Type: bug
crasbe
added
Impact: minor
maribu
approved these changes
Jul 28, 2025
Member
|
Thx a lot for the fix! If I'm not mistaken, this is your first PR to RIOT. So welcome to the RIOT contributors 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
The
motor_driver_initfunction mistakenly expected thatpwm_initsets the pwm device to the exact frequency requested. In reality it sets the frequency to the next highest possible frequency with the given resolution.The fix updates the code to properly check for the error return value 0.