gnrc/rpl: check old rank before removing parents#21585
gnrc/rpl: check old rank before removing parents#21585Teufelchen1 merged 1 commit intoRIOT-OS:masterfrom
Conversation
`gnrc_rpl_dodag_remove_all_parents` sets the node's rank in the DODAG to `GNRC_RPL_INFINITE_RANK`, so checking the (old) rank should be done before that function call.
crasbe
added
CI: ready for build
Teufelchen1
left a comment
Teufelchen1
left a comment
There was a problem hiding this comment.
LGTM. You tested it, right? (and it's not just an unchecked finding while reading code)
Yes :) I tested initially with #21586, and just now again also on the current master. Without this fix, there is some weird ping pong behavior where a parent, after I assume that the reason is that without the fix the if-branch is skipped and the trickle timer not reset, resulting in the child not being informed of the poisoned (i.e. infinite) parent rank. |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
4 participants
Contribution description
gnrc_rpl_dodag_remove_all_parentssets the node's rank toGNRC_RPL_INFINITE_RANK, so checking the (old) rank should be done before that function call.Testing procedure
See Testing procedure in #21586.
Issues/PRs references
Came up while testing #21586.