Skip to content

pkt: Initial import#2158

Merged
OlegHahm merged 2 commits intoRIOT-OS:masterfrom
miri64:pkt/feat/initial-import
Jan 14, 2015
Merged

pkt: Initial import#2158
OlegHahm merged 2 commits intoRIOT-OS:masterfrom
miri64:pkt/feat/initial-import

Conversation

@miri64
Copy link
Copy Markdown
Member

@miri64 miri64 commented Dec 8, 2014

This data type is bound to replace the (netdev_hlist_t *ulh, void *data) tuples in netapi and netdev.

@miri64 miri64 added Discussion: RFC The issue/PR is used as a discussion starting point about the item of the issue/PR Area: network Area: Networking Type: new feature The issue requests / The PR implemements a new feature for RIOT labels Dec 8, 2014
@miri64 miri64 added this to the Release 2014.12 milestone Dec 8, 2014
PeterKietzmann
PeterKietzmann reviewed Dec 8, 2014
View reviewed changes
sys/include/pkt.h Outdated
Copy link
Copy Markdown
Member

@PeterKietzmann PeterKietzmann Dec 8, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the

@miri64 miri64 force-pushed the pkt/feat/initial-import branch from 59fcd08 to 7c8a9c8 Compare December 14, 2014 13:40
@OlegHahm OlegHahm modified the milestones: Release 2014.12, Release NEXT MAJOR Dec 18, 2014
@OlegHahm OlegHahm added Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties and removed Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties labels Jan 6, 2015
This was referenced Jan 12, 2015
Closed
Merged
Closed
@miri64 miri64 force-pushed the pkt/feat/initial-import branch from ea893f2 to 0c62935 Compare January 13, 2015 03:05
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Jan 13, 2015

Addressed comments made in #2286

@miri64 miri64 mentioned this pull request Jan 13, 2015
Merged
@haukepetersen haukepetersen mentioned this pull request Jan 13, 2015
Closed
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Jan 13, 2015

From #2286

Regarding the API: I don't think we need a dedicated API for headers, by just working on a generic data structure we simplify/shorten code with the same results - in the end it's not the genuine user that is working inside the network stack - but people who know at least to some extend what they are doing...

No, this was the reason why I introduced this API in the first place, because I was doing the same thing over and over again, with operations that where all packet related. If we want to allocate arbitrary chunks in a buffer, fine, but than this API should be a wrapper for that, to prevent packet related code duplication in the different layer implementations.

@haukepetersen
Copy link
Copy Markdown
Contributor

haukepetersen commented Jan 13, 2015

Good point. I guess then we should merge this and see how it works out! -> ACK

@miri64 miri64 force-pushed the pkt/feat/initial-import branch from 1d51f12 to 57228a9 Compare January 13, 2015 22:46
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Jan 13, 2015

Squashed

@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented Jan 14, 2015

Kicked T.

miri64 added 2 commits January 14, 2015 07:04
@miri64
pkt: Initial import
99e2fec 
This data type is bound to replace the `(netdev_hlist_t *ulh, void
*data)` tuples in netapi and netdev.
@miri64
tests, pkt: add unittests for pkt
62544e6
@miri64 miri64 force-pushed the pkt/feat/initial-import branch from 57228a9 to 561d205 Compare January 14, 2015 06:05
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Jan 14, 2015

Rebased to master and adapted unittest includes to #2102.

@miri64 miri64 force-pushed the pkt/feat/initial-import branch from 561d205 to 62544e6 Compare January 14, 2015 06:17
OlegHahm added a commit that referenced this pull request Jan 14, 2015
@OlegHahm
Merge pull request #2158 from authmillenon/pkt/feat/initial-import
2d874af 
pkt: Initial import
@OlegHahm OlegHahm merged commit 2d874af into RIOT-OS:master Jan 14, 2015
@miri64 miri64 deleted the pkt/feat/initial-import branch January 14, 2015 07:33
@OlegHahm OlegHahm modified the milestone: Release 2015.12 Dec 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@haukepetersen haukepetersen

Labels

Area: network Area: Networking Discussion: RFC The issue/PR is used as a discussion starting point about the item of the issue/PR Type: new feature The issue requests / The PR implemements a new feature for RIOT

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@miri64 @haukepetersen @OlegHahm @cgundogan @PeterKietzmann