Skip to content

boards/nucleo-l412kb: enable ADC#21566

Merged
benpicco merged 4 commits intoRIOT-OS:masterfrom
krzysztof-cabaj:nucleo-l412kb-ADC
Jul 9, 2025
Merged

boards/nucleo-l412kb: enable ADC#21566
benpicco merged 4 commits intoRIOT-OS:masterfrom
krzysztof-cabaj:nucleo-l412kb-ADC

Conversation

@krzysztof-cabaj
Copy link
Copy Markdown
Contributor

@krzysztof-cabaj krzysztof-cabaj commented Jun 28, 2025 •
edited
Loading

Contribution description

This PR enables ADC for nucleo-l412kb board.

I don't have access to this boards, but because ADC pinout is the same as for nucleo-l432kc (see board manual tables 15 and 16) code should works fine. I compile code without any warnings.

Testing procedure

Flash the board using tests/periph/adc and tests/periph/vbat programs.

The outputs should be similar to the ones presented in #21238 (comment)

Issues/PRs references

None.

@github-actions github-actions bot added Platform: ARM Platform: This PR/issue effects ARM-based platforms Area: boards Area: Board ports Area: cpu Area: CPU/MCU ports labels Jun 28, 2025
@crasbe crasbe added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jun 28, 2025
@riot-ci
Copy link
Copy Markdown

riot-ci commented Jun 28, 2025

Murdock results

✔️ PASSED

7816da2 boards/nucleo-l412kb: add VBAT monitoring feature

Success Failures Total Runtime
10504 0 10504 18m:52s

Artifacts

maribu
maribu approved these changes Jun 28, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@maribu maribu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx a lot ❤️

The code looks good and I trust in your testing

@maribu maribu added this pull request to the merge queue Jun 28, 2025
@crasbe
Copy link
Copy Markdown
Contributor

crasbe commented Jun 28, 2025

The code looks good and I trust in your testing

Which testing 👀

I don't have access to this boards, [...]

But yeah, let's hope it works as it is similar enough.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 28, 2025
@krzysztof-cabaj
Copy link
Copy Markdown
Contributor Author

krzysztof-cabaj commented Jun 30, 2025

Thank you for your trust ... but as @crasbe notices I don't have this boards and only look at documentation for similar board and check if tests/periph/adc and tests/periph/vbat compile for this board with success.

BTW. There is probably some problem with Murdock - from few days all full merge at 2 o'clock failed, in most cases due to some bizzare timeouts. Moreover, failed test for this PR is associated with timeout, too ... and I don't think that this is this PR fault.

@crasbe
Copy link
Copy Markdown
Contributor

crasbe commented Jun 30, 2025

Yes, that error is unrelated to your code. The timing tests are a bit finnicky lately which probably correlates to load on the CI servers.

I was waiting for a response from @maribu before putting it back on the queue.

@krzysztof-cabaj
Copy link
Copy Markdown
Contributor Author

krzysztof-cabaj commented Jul 1, 2025

@maribu - can me move this PR little forward?

@benpicco benpicco added this pull request to the merge queue Jul 9, 2025
Merged via the queue into RIOT-OS:master with commit 9356f2a Jul 9, 2025
28 checks passed
@Teufelchen1 Teufelchen1 added this to the Release 2025.07 milestone Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maribu maribu maribu approved these changes

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@vincent-d vincent-d Awaiting requested review from vincent-d vincent-d is a code owner

Assignees

No one assigned

Labels

Area: boards Area: Board ports Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

Release 2025.07

Development

Successfully merging this pull request may close these issues.

6 participants

@krzysztof-cabaj @riot-ci @crasbe @maribu @benpicco @Teufelchen1