examples/gnrc_lorawan: simplyfy configuration a bit#21526
Merged
crasbe merged 1 commit intoRIOT-OS:masterfrom Jun 27, 2025
Merged
examples/gnrc_lorawan: simplyfy configuration a bit#21526crasbe merged 1 commit intoRIOT-OS:masterfrom
crasbe merged 1 commit intoRIOT-OS:masterfrom
Conversation
crasbe
added
Type: cleanup
mguetschow
reviewed
Jun 3, 2025
Contributor
mguetschow
left a comment
mguetschow
left a comment
There was a problem hiding this comment.
Looks sensible to me. However, the README reads to me as if the decision for OTAA or ABP can be done at run-time, and this Makefile reads like it would be a compile-time decision. Could you clarify? (I have no prior knowledge with lorawan)
Contributor
Author
|
Both can be used in one binary but there is one default. The OTAA can be disabled at runtime in which case the default becomes ABP. |
mguetschow
approved these changes
Jun 3, 2025
Contributor
mguetschow
left a comment
mguetschow
left a comment
There was a problem hiding this comment.
Looks good now, please squash :)
fabian18
force-pushed
the
pr/examples_gnrc_lorawan_cleaner_config
branch
from
b12445a to
53520dd
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
|
Looks like this will need a rebase for |
fabian18
force-pushed
the
pr/examples_gnrc_lorawan_cleaner_config
branch
from
53520dd to
5222ef5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
I struggled a bit to figure out what to set and what to enable for
examples/networking/gnrc/gnrc_lorawan.I would consider this a tiny clean up. Maybe you agree.
Testing procedure
Issues/PRs references
split out from #21202