tests/drivers/{st77xx,ili9341}: fix coordinates in lcd_fill()#21518
tests/drivers/{st77xx,ili9341}: fix coordinates in lcd_fill()#21518crasbe merged 1 commit intoRIOT-OS:masterfrom
Conversation
camoz
requested review from
MichelRottleuthner,
aabadie and
leandrolanzieri
as code owners
|
In the BENCHMARK_FUNC macro I did a different line breaking to align with the formatting of the second BENCHMARK_FUNC macro below. |
crasbe
added
Type: bug
|
Thank you for your first contribution to RIOT OS :) I tested the changes on an ST7735 display and everything still works as expected. A ILI9341 display will arrive soon for testing. In the meantime it would be good if you could change the commit message. Currently it is a bit unclear which of the drivers are changed by the commit, so something like GitHub has a nice tutorial on how to do that: |
The lcd_fill() argument x2 (y2) must be less than dev.params->lines (dev.params->rgb_channels) to not draw to invalid LCD coordinates.
camoz
changed the title
|
Fixed, thank you for the link. (My intention with the prefix Let me know if this PR needs further adjustments. |
|
Thank you for addressing the small nitpick and congratulations on your first merged PR :) |
4 participants
The lcd_fill() argument x2 (y2) must be less than dev.params->lines (dev.params->rgb_channels) to not draw to invalid LCD coordinates.
Tested on a Xiao nRF52840 with a ST7735 attached.
This is my first contribution to RIOT and to be honest I did not completely read the Linux kernel coding style guide, but I wrapped the long lines according to https://docs.kernel.org/process/coding-style.html#breaking-long-lines-and-strings.