Skip to content

features.yaml: add feather_shield feature#21513

Merged
mguetschow merged 1 commit intoRIOT-OS:masterfrom
mguetschow:shield-feather
May 28, 2025
Merged

features.yaml: add feather_shield feature#21513
mguetschow merged 1 commit intoRIOT-OS:masterfrom
mguetschow:shield-feather

Conversation

@mguetschow
Copy link
Copy Markdown
Contributor

@mguetschow mguetschow commented May 27, 2025

Contribution description

Same as xiao_shield for all Feather boards supported by RIOT. Not used yet as no extension boards for Feather's are currently defined (and I'm not sure how we would even model them right now in our build system).

Testing procedure

Briefly skim over the changes, CI should be green.

@github-actions github-actions bot added Area: doc Area: Documentation Area: build system Area: Build system Area: boards Area: Board ports labels May 27, 2025
@mguetschow mguetschow added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 27, 2025
@crasbe crasbe added the Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation label May 27, 2025
crasbe
crasbe reviewed May 27, 2025
View reviewed changes
crasbe
crasbe approved these changes May 27, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@crasbe crasbe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpick, please squash directly.

@riot-ci
Copy link
Copy Markdown

riot-ci commented May 27, 2025 •
edited
Loading

Murdock results

✔️ PASSED

1411068 features.yaml: add feather_shield feature

Success Failures Total Runtime
10383 0 10383 14m:58s

Artifacts

@mguetschow mguetschow enabled auto-merge May 28, 2025 08:49
@mguetschow mguetschow added this pull request to the merge queue May 28, 2025
Merged via the queue into RIOT-OS:master with commit cd8bb88 May 28, 2025
25 checks passed
@mguetschow mguetschow deleted the shield-feather branch May 28, 2025 11:56
@maribu
Copy link
Copy Markdown
Member

maribu commented May 31, 2025

Not used yet as no extension boards for Feather's are currently defined (and I'm not sure how we would even model them right now in our build system).

There are features that declare a corresponding mapping, see

RIOT/features.yaml

Line 365 in cd8bb88

- title: Arduino Features

E.g. using this pinout:

pinout feather

There are GPIO pins D0 to D13 and A0 to A5. Those should be mapped as done in e.g.

RIOT/boards/nrf52840dk/include/arduino_iomap.h

Line 74 in cd8bb88

#define ARDUINO_PIN_0 GPIO_PIN(1, 1)

then the arduino_pins feature would be declared to indicate presence of GPIO pin mapping. For SPI, UART, I2C etc. are similar features and defines. You could also provide a new define to distinguish between multiple I2C position; as long as the naming is consistent between all Feather boards everything is fear game.

@Teufelchen1 Teufelchen1 added this to the Release 2025.07 milestone Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crasbe crasbe crasbe approved these changes

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

Assignees

No one assigned

Labels

Area: boards Area: Board ports Area: build system Area: Build system Area: doc Area: Documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

Release 2025.07

Development

Successfully merging this pull request may close these issues.

5 participants

@mguetschow @riot-ci @maribu @crasbe @Teufelchen1