Skip to content

sys/shell: rename shell_readline()#21506

Merged
crasbe merged 1 commit intoRIOT-OS:masterfrom
Teufelchen1:fix/shell_readline
May 24, 2025
Merged

sys/shell: rename shell_readline()#21506
crasbe merged 1 commit intoRIOT-OS:masterfrom
Teufelchen1:fix/shell_readline

Conversation

@Teufelchen1
Copy link
Copy Markdown
Contributor

Hello 🦫,

the recent PR #21505 exposed the shell readline function. This PR adjust its name as proposed by @mguetschow

@github-actions github-actions bot added the Area: sys Area: System label May 23, 2025
@crasbe crasbe added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels May 23, 2025
@riot-ci
Copy link
Copy Markdown

riot-ci commented May 23, 2025

Murdock results

✔️ PASSED

e98426e sys/shell: rename shell_readline()

Success Failures Total Runtime
10363 0 10363 12m:02s

Artifacts

Copy link
Copy Markdown
Contributor

@mguetschow mguetschow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! When Murdock is happy, I'll be happy :)

@Teufelchen1 Teufelchen1 force-pushed the fix/shell_readline branch from 2bed63c to a9f9d49 Compare May 23, 2025 12:50
@crasbe
Copy link
Copy Markdown
Contributor

crasbe commented May 23, 2025

Perhaps you could change the commit message and title to "sys/shell: rename shell_readline()"?

@Teufelchen1 Teufelchen1 changed the title shell: rename shell_readline() sys/shell: rename shell_readline() May 24, 2025
@Teufelchen1 Teufelchen1 force-pushed the fix/shell_readline branch from a9f9d49 to e98426e Compare May 24, 2025 16:28
@Teufelchen1
Copy link
Copy Markdown
Contributor Author

Perhaps you could change the commit message and title to "sys/shell: rename shell_readline()"?

Perhaps I can. Maybe not. Who knows.

@crasbe crasbe added this pull request to the merge queue May 24, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 24, 2025
@crasbe crasbe added this pull request to the merge queue May 24, 2025
Merged via the queue into RIOT-OS:master with commit fc2e219 May 24, 2025
25 checks passed
@Teufelchen1 Teufelchen1 added this to the Release 2025.07 milestone Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants