cpu/samd5x: improve isr buffer handling#21486
Merged
kfessel merged 2 commits intoRIOT-OS:masterfrom May 22, 2025
Merged
Conversation
github-actions
bot
added
Platform: ARM
mguetschow
reviewed
May 13, 2025
cpu/samd5x/periph/can.c
Outdated
| printf("Tx buffer|\t0x%08" PRIx32 "|\t%" PRIu32 "\n", | ||
| (uint32_t)(dev->msg_ram_conf.tx_fifo_queue), | ||
| (uint32_t)(ARRAY_SIZE(dev->msg_ram_conf.tx_fifo_queue))); | ||
| printf("Standard filters|\t%p|\t%u\n", (dev->msg_ram.std_filter), |
Contributor
There was a problem hiding this comment.
Hu, why going from formatting macros back to %p and %u?
Contributor
Author
There was a problem hiding this comment.
readability avoid unnecessary cast - i somehow thought newlib is C99 compliant -- will fix that
Contributor
Author
There was a problem hiding this comment.
for that array size thing i stayed with u
benpicco
reviewed
May 13, 2025
benpicco
reviewed
May 13, 2025
benpicco
reviewed
May 13, 2025
kfessel
added
the
CI: ready for build
kfessel
changed the title
Contributor
Author
|
May I squash ? |
kfessel
force-pushed
the
p-can-isr-buffer-handling
branch
from
1fd9f34 to
1d3fea3
Compare
crasbe
added
Type: enhancement
kfessel
commented
May 16, 2025
maribu
reviewed
May 20, 2025
maribu
reviewed
May 20, 2025
Member
maribu
left a comment
maribu
left a comment
There was a problem hiding this comment.
see inline. feel free to squash at will
kfessel
force-pushed
the
p-can-isr-buffer-handling
branch
from
415f3b2 to
3139df7
Compare
maribu
reviewed
May 21, 2025
kfessel
force-pushed
the
p-can-isr-buffer-handling
branch
from
c44244c to
ca5a322
Compare
maribu
approved these changes
May 21, 2025
Contributor
Author
|
Thanks for the reviewes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Testing procedure
Issues/PRs references