examples/basic/subfolders: switch from DIRS to EXTERNAL_MODULE_DIRS#21476
Merged
mguetschow merged 2 commits intoRIOT-OS:masterfrom May 9, 2025
Merged
Conversation
github-actions
bot
added
Area: doc
mguetschow
added
the
CI: ready for build
maribu
approved these changes
May 9, 2025
mguetschow
force-pushed
the
examples-subfolders-external-module
branch
from
58e87fc to
1f674a4
Compare
Member
|
The nightly failed on the samr21-xpro on this test (and everything else passed). I think nothing else was merged yesterday, so chances are high this was the only test run, as the rest was still in the cache. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
We have
EXTERNAL_MODULE_DIRSin RIOT, which are favored instead of manually messing withDIRS, especially because they get the dependency resolution right. Maybe I was not aware of that back when I introduced the example in #20024, so let's fix this up now.Testing procedure
Examples should still build in the CI, and now also be tested successfully.
Issues/PRs references
Triggered by #21442