gnrc/ipv6/nib: clean up gnrc_ipv6_nib_get_next_hop_l2addr()#21454
Merged
benpicco merged 1 commit intoRIOT-OS:masterfrom Jul 24, 2025
Merged
Conversation
benpicco
changed the title
gnrc_ipv6_nib_get_next_hop_l2addr()
benpicco
added
the
CI: ready for build
crasbe
added
the
Type: cleanup
benpicco
force-pushed
the
gnrc_ipv6_nib_get_next_hop_l2addr-cleanup
branch
from
d8c2194 to
6985ccc
Compare
maribu
reviewed
May 7, 2025
Member
maribu
left a comment
maribu
left a comment
There was a problem hiding this comment.
I assume that this is mostly replacing the break; used as hidden goto with a non-hidden goto?
The default diff tool used by Github is doing a really poor job on indent changes, matching unrelated } lines that now due to the indent change happen to be on the same line.
benpicco
force-pushed
the
gnrc_ipv6_nib_get_next_hop_l2addr-cleanup
branch
from
6985ccc to
80cfb41
Compare
Teufelchen1
approved these changes
Jun 24, 2025
Contributor
Teufelchen1
left a comment
Teufelchen1
left a comment
There was a problem hiding this comment.
That is indeed very hard to read in the github diff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
gnrc_ipv6_nib_get_next_hop_l2addr()has a rather high code complexity which makes it hard to understand and easy to introduce errors.Reduce the amount of nested if branches to make the function easier to understand.
This should contain no functional / logic changes.
Testing procedure
Issues/PRs references