tests/unittests/tests-core-clist: improve unit test#21402
Merged
maribu merged 2 commits intoRIOT-OS:masterfrom Apr 23, 2025
Merged
tests/unittests/tests-core-clist: improve unit test#21402maribu merged 2 commits intoRIOT-OS:masterfrom
maribu merged 2 commits intoRIOT-OS:masterfrom
Conversation
maribu
added
Type: enhancement
maribu
force-pushed
the
tests/unittests/clist-sort
branch
from
144b2cc to
4d305ec
Compare
crasbe
reviewed
Apr 13, 2025
Contributor
crasbe
left a comment
crasbe
left a comment
There was a problem hiding this comment.
Disclaimer: I still don't know anything about clist :D
There are also two static errors about line length.
mguetschow
reviewed
Apr 14, 2025
Contributor
mguetschow
left a comment
mguetschow
left a comment
There was a problem hiding this comment.
Nice one! Can we still get this merged today?
One of the commits (and the PR name) has a typo.
maribu
changed the title
- Iterate of different lengths of unsorted data to also cover corner case one-item list - Actually check that the list is sorted afterwards (and not just that the maximum got sorted in last) - Actually check that the list was stable-sorted (as the API doc promises a stable sort) - Increase the length of the input data for better test coverage - Check that no elements get lost while sorting Co-authored-by: crasbe <[email protected]>
This should fix the column length warning of the static tests.
maribu
force-pushed
the
tests/unittests/clist-sort
branch
from
0da3548 to
60e3102
Compare
Member
Author
|
Thx! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Testing procedure
Issues/PRs references
None