core/msg: fix msg_avail_thread() and msg_avail()#21400
Merged
maribu merged 1 commit intoRIOT-OS:masterfrom Apr 15, 2025
Merged
Conversation
github-actions
bot
added
the
Area: core
maribu
added
Type: bug
github-actions
bot
added
the
Process: missing approvals
maribu
changed the title
msg_avail_thread() and msg_avail()msg_avail_thread() and msg_avail()
mguetschow
reviewed
Apr 14, 2025
3 tasks
mguetschow
reviewed
Apr 15, 2025
mguetschow
approved these changes
Apr 15, 2025
Contributor
mguetschow
left a comment
mguetschow
left a comment
There was a problem hiding this comment.
LGTM, but CI complains.
This now ensures race-free access to the CIB tracking the number of messages queued in the ringbuffer for a given thread. In addition, `msg_avail_thread()` now checks if the provided pid refers to a thread that is currently existing. Co-authored-by: Mikolai Gütschow <[email protected]>
benpicco
approved these changes
Apr 15, 2025
github-actions
bot
removed
the
Process: missing approvals
Member
Author
|
Thx a lot :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This now ensures race-free access to the CIB tracking the number of messages queued in the ringbuffer for a given thread.
In addition,
msg_avail_thread()now checks if the provided pid refers to a thread that is currently existing.Testing procedure
msg_avail()should still passmsg_avail_thread()andmsg_avail()should no longer be racyIssues/PRs references
None