Skip to content

CODING_CONVENTION.md: migrate to #pragma once#21369

Merged
maribu merged 1 commit intoRIOT-OS:masterfrom
mguetschow:pragma-once-doc
Apr 7, 2025
Merged

CODING_CONVENTION.md: migrate to #pragma once#21369
maribu merged 1 commit intoRIOT-OS:masterfrom
mguetschow:pragma-once-doc

Conversation

@mguetschow
Copy link
Copy Markdown
Contributor

@mguetschow mguetschow commented Apr 7, 2025

Contribution description

As discussed in the previous to last VMA and last weekly, let's allow and promote #pragma once usage instead of header guards. Also see #21335

Testing procedure

Read the coding convention.

Related issues/PRs

#21367

@mguetschow mguetschow requested a review from jia200x as a code owner April 7, 2025 09:39
@github-actions github-actions bot added the Area: doc Area: Documentation label Apr 7, 2025
@mguetschow mguetschow added the Process: needs >1 ACK Integration Process: This PR requires more than one ACK label Apr 7, 2025
@github-actions github-actions bot added the Process: missing approvals Integration Process: PR needs more ACKS (handled by action) label Apr 7, 2025
@mguetschow mguetschow added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs labels Apr 7, 2025
@riot-ci
Copy link
Copy Markdown

riot-ci commented Apr 7, 2025

Murdock results

✔️ PASSED

357a37c CODING_CONVENTION.md: migrate to #pragma once

Success Failures Total Runtime
1 0 1 01m:14s

Artifacts

crasbe
crasbe reviewed Apr 7, 2025
View reviewed changes
@maribu maribu removed the Process: missing approvals Integration Process: PR needs more ACKS (handled by action) label Apr 7, 2025
@maribu maribu added this pull request to the merge queue Apr 7, 2025
Merged via the queue into RIOT-OS:master with commit 3c64923 Apr 7, 2025
29 of 36 checks passed
@mguetschow
Copy link
Copy Markdown
Contributor Author

mguetschow commented Apr 7, 2025

Thanks everyone! 🎉

@mguetschow mguetschow deleted the pragma-once-doc branch April 7, 2025 13:39
@kfessel
Copy link
Copy Markdown
Contributor

kfessel commented Apr 7, 2025

🎉

This was referenced Apr 7, 2025
Merged
Closed
@mguetschow mguetschow added this to the Release 2025.04 milestone Apr 8, 2025
@maribu maribu mentioned this pull request May 5, 2025
Merged
7 tasks
@mguetschow mguetschow mentioned this pull request May 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kfessel kfessel kfessel approved these changes

@benpicco benpicco benpicco approved these changes

@crasbe crasbe crasbe approved these changes

@maribu maribu maribu approved these changes

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@miri64 miri64 Awaiting requested review from miri64

@OlegHahm OlegHahm Awaiting requested review from OlegHahm

Assignees

No one assigned

Labels

Area: doc Area: Documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Process: needs >1 ACK Integration Process: This PR requires more than one ACK

Projects

None yet

Milestone

Release 2025.04

Development

Successfully merging this pull request may close these issues.

6 participants

@mguetschow @riot-ci @kfessel @benpicco @crasbe @maribu