static-test/vera++: reduce linelength false positives#21364
Closed
kfessel wants to merge 3 commits intoRIOT-OS:masterfrom
Closed
static-test/vera++: reduce linelength false positives#21364kfessel wants to merge 3 commits intoRIOT-OS:masterfrom
kfessel wants to merge 3 commits intoRIOT-OS:masterfrom
Conversation
78ffff9 to
1d935c0
Compare
fb05b02 to
d739903
Compare
mguetschow
reviewed
Apr 7, 2025
| @@ -1,37 +0,0 @@ | |||
| name: check-commits | |||
Contributor
There was a problem hiding this comment.
I doubt it was on purpose to remove all those files? 👀
Contributor
|
Replaced by #21671. Also personally I disagree with disabling the warnings for inline comments. When the line is becoming soooo long, the purpose of the inline comment is not given anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this ignores some line length warnings that are commonly ignored in PR review
Contribution description
Testing procedure
Issues/PRs references