Skip to content

buildsystem: Enable -Wdocumentation for LLVM#21358

Merged
mguetschow merged 1 commit intoRIOT-OS:masterfrom
maribu:build_system/warn-about-broken-doc
Apr 4, 2025
Merged

buildsystem: Enable -Wdocumentation for LLVM#21358
mguetschow merged 1 commit intoRIOT-OS:masterfrom
maribu:build_system/warn-about-broken-doc

Conversation

@maribu
Copy link
Copy Markdown
Member

@maribu maribu commented Apr 4, 2025

Contribution description

This enables warnings for incorrect Doxygen comments when build with LLVM. To my experience, LLVM provides a low false positive rate (e.g. it does not complain about undocumented internal macros) and has very helpful output.

This disable -Wdocumentation-deprecated-sync for now, as we do not deprecate code with attributes yet.

The warnings are not set as errors, so that we can enable this without breaking builds.

Testing procedure

make TOOLCHAIN=llvm BOARD=<SOME_BOARD> -C <path/to/some/app>

Should now warn about broken doc

Issues/PRs references

None

This enables warnings for incorrect Doxygen comments when build with
LLVM. To my experience, LLVM provides a low false positive rate
(e.g. it does not complain about undocumented internal macros) and has
very helpful output.

This disable `-Wdocumentation-deprecated-sync` for now, as we do not
deprecate code with attributes yet.

The warnings are not set as errors, so that we can enable this without
breaking builds.
@github-actions github-actions bot added Area: build system Area: Build system Area: toolchain Area: toolchains; everything related to compilation, libc, linking, … labels Apr 4, 2025
@maribu maribu added Type: new feature The issue requests / The PR implemements a new feature for RIOT CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed Area: toolchain Area: toolchains; everything related to compilation, libc, linking, … labels Apr 4, 2025
@riot-ci
Copy link
Copy Markdown

riot-ci commented Apr 4, 2025

Murdock results

✔️ PASSED

d838c6a buildsystem: Enable -Wdocumentation for LLVM

Success Failures Total Runtime
10280 0 10280 10m:30s

Artifacts

@maribu
Copy link
Copy Markdown
Member Author

maribu commented Apr 4, 2025

Copy link
Copy Markdown
Contributor

@mguetschow mguetschow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea, thanks!

@mguetschow mguetschow enabled auto-merge April 4, 2025 09:26
@mguetschow mguetschow added this pull request to the merge queue Apr 4, 2025
Merged via the queue into RIOT-OS:master with commit eb56a56 Apr 4, 2025
29 checks passed
@mguetschow mguetschow added this to the Release 2025.04 milestone Apr 8, 2025
@maribu maribu deleted the build_system/warn-about-broken-doc branch January 13, 2026 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: build system Area: Build system CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: new feature The issue requests / The PR implemements a new feature for RIOT

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants