The boards/common/adafruit-nrf52-bootloader/doc.md has to be adapted as well and there are some references to the old name in the doc.mds of the Feather nRF52840 Express and Sense.

Also the tests/sys/fido2_ctap_hid/Makefile, tests/drivers/lsm6dsxx/Makefile, tests/sys/xtimer_now32_overflow/Makefile and
tests/sys/fido2_ctap/Makefile still have the old board format.

Edit: I found those with grep -Rnw . -e "feather-nrf52840".

Thanks for double-checking, should be fixed now.

You could use the opportunity to adapt the headers according to #21335, but that's no must.

Personally I think the warning introduced in #21242 should've been red because now you don't really notice it, but that's too late now I guess 😅

I'm not sure if it would be better to name the fixup PRs something like tests/*: rename to adafruit-feather-nrf52840-*, since it's another directory? idk

Otherwise everything looks good to me, I can physically test it when I'm home with the nRF52840DK pretending to be a Feather.

You could use the opportunity to adapt the headers according to #21335, but that's no must.

I'd rather not, to be honest, to keep the changes small for this commit. Still waiting for @KSKNico to provide the next subtree PR :)

Personally I think the warning introduced in #21242 should've been red because now you don't really notice it, but that's too late now I guess 😅

It's never too late: #21352

I'm not sure if it would be better to name the fixup PRs something like tests/*: rename to adafruit-feather-nrf52840-*, since it's another directory? idk

I've now squashed them together anyways.

Murdock results

✔️ PASSED

e92ac97 examples/**/nimble_gatt: increase answer buffer for longer BOARD names

Artifacts

• Documentation preview

This is the cause of the build failure. Apparently with adafruit-feather-nrf52840-express, the string is longer than 100 letters (101 to be exact 😅 ).

100 ways to break your builds :P

Updated to 120 bytes and confirmed to still work with feather-nrf52840-sense and my smartphone :)

...and was so free to squash already

I'm still not super happy that everything is one commit, but I don't think it's necessary to split it up again.

Thanks for your review!