Skip to content

drivers/sdmmc/sdmmc_sdhc: remove DMA check#21260

Merged
fabian18 merged 1 commit intoRIOT-OS:masterfrom
fabian18:pr/sdmmc_sdhc_guard_dma_check
Mar 19, 2025
Merged

drivers/sdmmc/sdmmc_sdhc: remove DMA check#21260
fabian18 merged 1 commit intoRIOT-OS:masterfrom
fabian18:pr/sdmmc_sdhc_guard_dma_check

Conversation

@fabian18
Copy link
Copy Markdown
Contributor

@fabian18 fabian18 commented Mar 1, 2025

Contribution description

The DMA assertion may trigger without a reason in sdmmc_sdhc.c.
There is currently no MCU that implements sdhc_conf_twith DMA support, so the PR simply removes the assertion.

Testing procedure

Issues/PRs references

@fabian18
drivers/sdmmc/sdmmc_sdhc: remove DMA check
803588d 
At the moment there is no MCU that implements sdhc_conf_t and supports DMA with it.
@github-actions github-actions bot added the Area: drivers Area: Device drivers label Mar 1, 2025
@fabian18 fabian18 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 1, 2025
@riot-ci
Copy link
Copy Markdown

riot-ci commented Mar 1, 2025

Murdock results

✔️ PASSED

803588d drivers/sdmmc/sdmmc_sdhc: remove DMA check

Success Failures Total Runtime
10270 0 10271 10m:39s

Artifacts

@benpicco benpicco requested a review from gschorcht March 1, 2025 19:16
@gschorcht
Copy link
Copy Markdown
Contributor

gschorcht commented Mar 15, 2025 •
edited
Loading

There is currently no MCU that implements sdhc_conf_twith DMA support, so the PR simply removes the assertion.

SAM D5x/E5x MCUs support DMA access (both SDMA and ADMA2), but it is not actually used. I don't know if we will ever use DMA for this driver. Since sdmmc_sdhc is an implementation of the SD Host Controller Simplified Specification Version, which could be used by different MCUs implementing this specification, we would need a common API for DMA access before the sdmmc_sdhc module could use DMA.

We can remove the check for the moment, but we have to keep this in mind.

gschorcht
gschorcht reviewed Mar 15, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@gschorcht gschorcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this check as long as the driver doesn't implement DMA.

@fabian18
Copy link
Copy Markdown
Contributor Author

fabian18 commented Mar 19, 2025

SAM D5x/E5x MCUs support DMA access

If I got it right from https://www.mouser.de/datasheet/2/268/SAM_D5x_E5x_Family_Data_Sheet_DS60001507-3107027.pdf, DMA is not applicable for the SDHC.

Thanks for approval.

@fabian18 fabian18 added this pull request to the merge queue Mar 19, 2025
Merged via the queue into RIOT-OS:master with commit fab3a1d Mar 19, 2025
28 checks passed
@mguetschow mguetschow added this to the Release 2025.04 milestone Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gschorcht gschorcht gschorcht approved these changes

Assignees

No one assigned

Labels

Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR

Projects

None yet

Milestone

Release 2025.04

Development

Successfully merging this pull request may close these issues.

4 participants

@fabian18 @riot-ci @gschorcht @mguetschow