gnrc/ipv6/nib: improve debug output, declutter code#21256
Merged
crasbe merged 3 commits intoRIOT-OS:masterfrom Sep 5, 2025
Merged
gnrc/ipv6/nib: improve debug output, declutter code#21256crasbe merged 3 commits intoRIOT-OS:masterfrom
crasbe merged 3 commits intoRIOT-OS:masterfrom
Conversation
benpicco
added
the
Type: cleanup
Member
|
LGTM, but please, someone else do a proper review (currently not having the time for it). |
mguetschow
added
the
CI: ready for build
benpicco
force-pushed
the
sys/net/gnrc-fixes
branch
from
2673f07 to
034f783
Compare
crasbe
approved these changes
Jul 25, 2025
Contributor
crasbe
left a comment
crasbe
left a comment
There was a problem hiding this comment.
Looks sensible. I can't really test it (or rather: I don't know how to test it).
My understanding is that the _handle_pio function that does not have the abr parameter got deleted and the functions that handled it got a default-NULL value for abr, so that it is safe to call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
No functional changes, just clean up the code & debug output a bit.
Testing procedure
Issues/PRs references