cpu/esp32: Fixes of compile problems with GCC 14.2#21245
Merged
maribu merged 3 commits intoRIOT-OS:masterfrom Mar 2, 2025
Merged
cpu/esp32: Fixes of compile problems with GCC 14.2#21245maribu merged 3 commits intoRIOT-OS:masterfrom
maribu merged 3 commits intoRIOT-OS:masterfrom
Conversation
github-actions
bot
added
Area: pkg
gschorcht
added
Type: bug
benpicco
reviewed
Feb 26, 2025
cpu/esp32/stdatomic.c
Outdated
Comment on lines
+22
to
+24
| #if (__GNUC__ == 14) && (__GNUC_MINOR__ == 2) | ||
|
|
||
| #if defined(CPU_FAM_ESP32S2) || defined(CPU_FAM_ESP32C3) |
Contributor
There was a problem hiding this comment.
Suggested change
| #if (__GNUC__ == 14) && (__GNUC_MINOR__ == 2) | |
| #if defined(CPU_FAM_ESP32S2) || defined(CPU_FAM_ESP32C3) | |
| __attribute__((weak)) |
wouldn't this be more future-proof?
Contributor
Author
There was a problem hiding this comment.
I couldn't figure out exactly why __atomic_test_and_set is missing in GCC v14.2 for ESP32-S2 and ESP32-C3 while it exists for the other ESP32x variants 🤔 The problem was only mentioned in espressif/esp-idf#15167.
benpicco
approved these changes
Feb 28, 2025
Atomic built-in function __atomic_test_and_set seem to be missing in GCC 14.2.0 for some ESP32x SoCs.
gschorcht
force-pushed
the
cpu/esp32/fix_compile_problem_gcc_14.2
branch
from
0d7f39b to
4f136fb
Compare
maribu
approved these changes
Mar 2, 2025
Contributor
Author
|
Thanks for reviewing and merging |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR provides some small fixes of compile problems with the latest Espressif toolchain (GCC v14.2).
Testing procedure
Compilation with used Espressif toolchain (GCC v12.2) should still work in CI.
Issues/PRs references