Merged
Conversation
Neither of the steps allowed for any practical variation; this reduced boilerplate.
The APPLICATION_RUST_MODULE declaration is moved to a more prominent position, given that it is now not part of a cesspool of boilerplate any more.
chrysn
added
Area: build system
chrysn
requested review from
MichelRottleuthner,
aabadie and
leandrolanzieri
as code owners
The RUSTFLAGS need to be exported; passing them on through Docker is not required for this addition, but makes sense once we touch it because this invites callers to set them too.
chrysn
removed
Area: tests
This allows users (such as the riot-wrappers CI) to tune their cache directory to their application's caching needs.
github-actions
bot
added
Area: tests
mguetschow
approved these changes
Feb 24, 2025
Contributor
mguetschow
left a comment
mguetschow
left a comment
There was a problem hiding this comment.
Reasoning sound sensible to me, code changes are straightforward, CI still runs and also confirmed to still work locally. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Applications used to need to set 3 lines of Makefile, when really 1 should suffice.
This takes a bit of freedom from the applications, but I doubt that could be exercised: You can't have a Rust module build without platform support, and the baselib that is being built is part of the Makefile targets, so it couldn't be named any different.
Similarly, applications needed to set panic=abort in their (really: any used) profile, just so that native could build on stable. By setting that from the build system, the need to do that over and over in every example is removed.
Testing procedure