cpu/sam4s: add initial support with SAM4S-XPRO board#21201
Merged
dylad merged 4 commits intoRIOT-OS:masterfrom Feb 17, 2025
Merged
cpu/sam4s: add initial support with SAM4S-XPRO board#21201dylad merged 4 commits intoRIOT-OS:masterfrom
dylad merged 4 commits intoRIOT-OS:masterfrom
Conversation
dylad
requested review from
MrKevinWeiss,
jia200x and
leandrolanzieri
as code owners
github-actions
bot
added
Platform: ARM
crasbe
reviewed
Feb 8, 2025
Contributor
crasbe
left a comment
crasbe
left a comment
There was a problem hiding this comment.
I don't have the hardware to test this, but just two things I noticed while glancing over this.
mguetschow
reviewed
Feb 10, 2025
mguetschow
added
the
CI: ready for build
Member
Author
|
static-tests are happy ! |
benpicco
approved these changes
Feb 16, 2025
Contributor
benpicco
left a comment
benpicco
left a comment
There was a problem hiding this comment.
Looks good to me, feel free to squash!
Signed-off-by: dylad <[email protected]>
Signed-off-by: dylad <[email protected]>
dylad
force-pushed
the
pr/cpu/sam4s/add_support
branch
from
ba6bc9a to
9e920b2
Compare
Member
Author
|
I've addressed @benpicco's comments and squashed. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Member
Author
|
Ah Murdock catches something. |
This commit allows to share GPIO, Timers and UARTs driver across SAM3/SAM4s MCUs as they relies on the same IPs Signed-off-by: dylad <[email protected]>
Signed-off-by: dylad <[email protected]>
dylad
force-pushed
the
pr/cpu/sam4s/add_support
branch
from
9e920b2 to
363fb75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR adds initial support for SAM4s MCUs from Microchip (formerly Atmel) and its sam4s-xpro board.
There are a bit old already, but still produced by Microchip and their headers files are already in-tree.
This family is pretty close to SAM3 (which we already support through
arduino-due) except that this is a Cortex-M4 which runs a little faster.Since peripherals are the same, I've moved GPIOs, Timer and UART driver to
cpu/sam_common.I plan to move the remaining drivers (if relevant) in followup PRs.
Testing procedure
Get a
sam4s-xproand run any tests involving UART/Timers/GPIOs.For the record here is the output of tests/sys/shell running on sam4s-xpro:
Issues/PRs references
None.