Skip to content

Driver for Freescale MMA8652 Accelerometer#2119

Merged
PeterKietzmann merged 2 commits intoRIOT-OS:masterfrom
jfischer-no:pr@mma8652
Jan 8, 2015
Merged

Driver for Freescale MMA8652 Accelerometer#2119
PeterKietzmann merged 2 commits intoRIOT-OS:masterfrom
jfischer-no:pr@mma8652

Conversation

@jfischer-no
Copy link
Copy Markdown
Contributor

@jfischer-no jfischer-no commented Dec 2, 2014

This PR add support for Freescale MMA8652 3-Axis 12-bit Digital Accelerometer.
This driver only implements basic functionality.

@OlegHahm OlegHahm added Area: drivers Area: Device drivers Type: new feature The issue requests / The PR implemements a new feature for RIOT labels Dec 2, 2014
OlegHahm
OlegHahm reviewed Dec 2, 2014
View reviewed changes
drivers/mma8652/Makefile
Copy link
Copy Markdown
Member

@OlegHahm OlegHahm Dec 2, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be necessary any more. Module name is generate from the directory name.

@PeterKietzmann
Copy link
Copy Markdown
Member

PeterKietzmann commented Dec 2, 2014

Wow nice work. Looks good!

@PeterKietzmann
Copy link
Copy Markdown
Member

PeterKietzmann commented Dec 2, 2014

Has someone the hardware by chance?

@jfischer-no
Copy link
Copy Markdown
Contributor Author

jfischer-no commented Dec 2, 2014

@PeterKietzmann We have limited samples of our Evaluation Bords (phyWAVE-A-Eval-Board). We can provide 1-2 hardware samples to riot developers. Please contact me for more information.

@PeterKietzmann PeterKietzmann mentioned this pull request Dec 3, 2014
Merged
@PeterKietzmann
Copy link
Copy Markdown
Member

PeterKietzmann commented Dec 9, 2014

This one works fine except for the vtimer. When the timer is fixed and the commits are squashed I give an ACK. But maybe we should wait until #2059 is merged.

@PeterKietzmann PeterKietzmann mentioned this pull request Dec 9, 2014
Merged
@jfischer-no jfischer-no changed the title pr@mma8652 Driver for Freescale MMA8652 Accelerometer Dec 10, 2014
@OlegHahm OlegHahm added the Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties label Jan 6, 2015
@jfischer-no
Copy link
Copy Markdown
Contributor Author

jfischer-no commented Jan 7, 2015

Tested with af03da0, OK.

@PeterKietzmann
Copy link
Copy Markdown
Member

PeterKietzmann commented Jan 7, 2015

vtimer works now. Needs squashing and waiting for #2059 to be merged. Then I'll give my final ACK.

@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented Jan 7, 2015

Ready to go.

@PeterKietzmann PeterKietzmann mentioned this pull request Jan 7, 2015
Merged
@PeterKietzmann
Copy link
Copy Markdown
Member

PeterKietzmann commented Jan 7, 2015

Okay, go

@PeterKietzmann
Copy link
Copy Markdown
Member

PeterKietzmann commented Jan 7, 2015

Ups, don't go yet. After merging the other drivers there are conflicts...

@PeterKietzmann
Copy link
Copy Markdown
Member

PeterKietzmann commented Jan 7, 2015

PS: Without looking deeper in it I assume you just need to rebase and solve conflicts in drivers/Makefile.include

@jfischer-no
Copy link
Copy Markdown
Contributor Author

jfischer-no commented Jan 8, 2015

rebased, but the merging of TMP006 was not working properly.

@jfischer-no jfischer-no mentioned this pull request Jan 8, 2015
Merged
@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented Jan 8, 2015

but the merging of TMP006 was not working properly

What do you mean?

@jfischer-no
Copy link
Copy Markdown
Contributor Author

jfischer-no commented Jan 8, 2015

Ignore it about TMP006, I'm a little confused today :-) 👻

@PeterKietzmann
Copy link
Copy Markdown
Member

PeterKietzmann commented Jan 8, 2015

@jfischer-phytec-iot what is the problem? Today I can't test this with hardware but compiling the test application for the stm32f4discovery board with the current master is successful.

@PeterKietzmann
Copy link
Copy Markdown
Member

PeterKietzmann commented Jan 8, 2015

Sorry ignore the last one please.It's outdated. I had some craftsmen here today working on the communication lines. That's why I couldn't go to the office and had no internet here for a while. So everything should be ready to merge.

@PeterKietzmann
Copy link
Copy Markdown
Member

PeterKietzmann commented Jan 8, 2015

And go

PeterKietzmann added a commit that referenced this pull request Jan 8, 2015
@PeterKietzmann
Merge pull request #2119 from jfischer-phytec-iot/pr@mma8652
77eab0c 
Driver for Freescale MMA8652 Accelerometer
@PeterKietzmann PeterKietzmann merged commit 77eab0c into RIOT-OS:master Jan 8, 2015
@jfischer-no jfischer-no deleted the pr@mma8652 branch January 31, 2015 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@PeterKietzmann PeterKietzmann

Labels

Area: drivers Area: Device drivers Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties Type: new feature The issue requests / The PR implemements a new feature for RIOT

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jfischer-no @PeterKietzmann @OlegHahm @haukepetersen