Skip to content

cpu: simplify folder structure#2118

Merged
LudwigKnuepfer merged 2 commits intoRIOT-OS:masterfrom
OlegHahm:simplify_cpu_folder_structure
Dec 8, 2014
Merged

cpu: simplify folder structure#2118
LudwigKnuepfer merged 2 commits intoRIOT-OS:masterfrom
OlegHahm:simplify_cpu_folder_structure

Conversation

@OlegHahm
Copy link
Copy Markdown
Member

@OlegHahm OlegHahm commented Dec 1, 2014

Closes #1273.

@OlegHahm OlegHahm added Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Platform: MSP Platform: This PR/issue effects MSP-based platforms labels Dec 1, 2014
@OlegHahm OlegHahm added this to the Release 2014.12 milestone Dec 1, 2014
@OlegHahm OlegHahm added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Dec 2, 2014
@OlegHahm OlegHahm assigned thomaseichinger and unassigned rousselk Dec 2, 2014
@OlegHahm
cpu: msp430: renamed msp430x16x to msp430fxyz
0c967c4
@OlegHahm
cpu: lpc2387: integrated lpc_common into lpc2387
17929a5 
Rationale 1: The common part made only sense for (some) NXP ARM7 MCUs,
but was misleading for MCUs like the LPC1768.

Rationale 2: The common part was only used by one specific MCU
implementation - no need to outsource it.
@OlegHahm OlegHahm force-pushed the simplify_cpu_folder_structure branch from 49de2ba to 17929a5 Compare December 2, 2014 16:47
@OlegHahm OlegHahm removed the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Dec 2, 2014
@OlegHahm
Copy link
Copy Markdown
Member Author

OlegHahm commented Dec 6, 2014

Anyone willing to review this simple change?

LudwigKnuepfer
LudwigKnuepfer reviewed Dec 8, 2014
View reviewed changes
boards/msb-430-common/Makefile.include
Copy link
Copy Markdown
Member

@LudwigKnuepfer LudwigKnuepfer Dec 8, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"xyz"?!

Copy link
Copy Markdown
Member Author

@OlegHahm OlegHahm Dec 8, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

variables

@thomaseichinger
Copy link
Copy Markdown
Member

thomaseichinger commented Dec 8, 2014

Sorry for the delay. ACK

LudwigKnuepfer pushed a commit that referenced this pull request Dec 8, 2014
Merge pull request #2118 from OlegHahm/simplify_cpu_folder_structure
0027f90 
cpu: simplify folder structure
@LudwigKnuepfer LudwigKnuepfer merged commit 0027f90 into RIOT-OS:master Dec 8, 2014
@OlegHahm OlegHahm deleted the simplify_cpu_folder_structure branch December 8, 2014 15:15
gschorcht added a commit to gschorcht/RIOT-Xtensa-ESP that referenced this pull request Feb 3, 2019
@gschorcht
sys/shell: cleanup the heap command approach
c9fe028 
Replaces the special heap command approach of the lpc_common module with a more general heap command approach. Module lpc_common was already removed with PR RIOT-OS#2118. PR RIOT-OS#2118 integrated cpu/lpc_common code in cpu/lpc2387. With PR RIOT-OS#3530 special heap handling for cpu/lpc2387 was replaced by newlib memory management which uses _sbrk_r to allocate chunks from the heap. _sbrk_r uses _sheap and _eheap symbols that are defined in lpc2387.ld and can be used together with mallinfo function for heap statistics.
gschorcht added a commit to gschorcht/RIOT-Xtensa-ESP that referenced this pull request Feb 5, 2019
@gschorcht
sys/shell: cleanup the heap command approach
02e529a 
Replaces the special heap command approach of the lpc_common module with a more general heap command approach. Module lpc_common was already removed with PR RIOT-OS#2118. PR RIOT-OS#2118 integrated cpu/lpc_common code in cpu/lpc2387. With PR RIOT-OS#3530 special heap handling for cpu/lpc2387 was replaced by newlib memory management which uses _sbrk_r to allocate chunks from the heap. _sbrk_r uses _sheap and _eheap symbols that are defined in lpc2387.ld and can be used together with mallinfo function for heap statistics.
gschorcht added a commit to gschorcht/RIOT-Xtensa-ESP that referenced this pull request Feb 6, 2019
@gschorcht
sys/shell: cleanup the heap command approach
43e389e 
Replaces the special heap command approach of the lpc_common module with a more general heap command approach. Module lpc_common was already removed with PR RIOT-OS#2118. PR RIOT-OS#2118 integrated cpu/lpc_common code in cpu/lpc2387. With PR RIOT-OS#3530 special heap handling for cpu/lpc2387 was replaced by newlib memory management which uses _sbrk_r to allocate chunks from the heap. _sbrk_r uses _sheap and _eheap symbols that are defined in lpc2387.ld and can be used together with mallinfo function for heap statistics.
gschorcht added a commit to gschorcht/RIOT-Xtensa-ESP that referenced this pull request Feb 6, 2019
@gschorcht
sys/shell: cleanup the heap command approach
b364471 
Replaces the special heap command approach of the lpc_common module with a more general heap command approach. Module lpc_common was already removed with PR RIOT-OS#2118. PR RIOT-OS#2118 integrated cpu/lpc_common code in cpu/lpc2387. With PR RIOT-OS#3530 special heap handling for cpu/lpc2387 was replaced by newlib memory management which uses _sbrk_r to allocate chunks from the heap. _sbrk_r uses _sheap and _eheap symbols that are defined in lpc2387.ld and can be used together with mallinfo function for heap statistics.
gschorcht added a commit to gschorcht/RIOT-Xtensa-ESP that referenced this pull request Apr 15, 2019
@gschorcht
sys/shell: cleanup the heap command approach
70d8ec0 
Replaces the special heap command approach of the lpc_common module with a more general heap command approach. Module lpc_common was already removed with PR RIOT-OS#2118. PR RIOT-OS#2118 integrated cpu/lpc_common code in cpu/lpc2387. With PR RIOT-OS#3530 special heap handling for cpu/lpc2387 was replaced by newlib memory management which uses _sbrk_r to allocate chunks from the heap. _sbrk_r uses _sheap and _eheap symbols that are defined in lpc2387.ld and can be used together with mallinfo function for heap statistics.
gschorcht added a commit to gschorcht/RIOT-Xtensa-ESP that referenced this pull request Sep 5, 2019
@gschorcht
sys/shell: cleanup the heap command approach
b5449de 
Replaces the special heap command approach of the lpc_common module with a more general heap command approach. Module lpc_common was already removed with PR RIOT-OS#2118. PR RIOT-OS#2118 integrated cpu/lpc_common code in cpu/lpc2387. With PR RIOT-OS#3530 special heap handling for cpu/lpc2387 was replaced by newlib memory management which uses _sbrk_r to allocate chunks from the heap. _sbrk_r uses _sheap and _eheap symbols that are defined in lpc2387.ld and can be used together with mallinfo function for heap statistics.
gschorcht added a commit to gschorcht/RIOT-Xtensa-ESP that referenced this pull request Sep 5, 2019
@gschorcht
sys/shell: cleanup the heap command approach
140987f 
Replaces the special heap command approach of the lpc_common module with a more general heap command approach. Module lpc_common was already removed with PR RIOT-OS#2118. PR RIOT-OS#2118 integrated cpu/lpc_common code in cpu/lpc2387. With PR RIOT-OS#3530 special heap handling for cpu/lpc2387 was replaced by newlib memory management which uses _sbrk_r to allocate chunks from the heap. _sbrk_r uses _sheap and _eheap symbols that are defined in lpc2387.ld and can be used together with mallinfo function for heap statistics.
gdoffe pushed a commit to gdoffe/RIOT that referenced this pull request Dec 17, 2019
@gschorcht @gdoffe
sys/shell: cleanup the heap command approach
1485010 
Replaces the special heap command approach of the lpc_common module with a more general heap command approach. Module lpc_common was already removed with PR RIOT-OS#2118. PR RIOT-OS#2118 integrated cpu/lpc_common code in cpu/lpc2387. With PR RIOT-OS#3530 special heap handling for cpu/lpc2387 was replaced by newlib memory management which uses _sbrk_r to allocate chunks from the heap. _sbrk_r uses _sheap and _eheap symbols that are defined in lpc2387.ld and can be used together with mallinfo function for heap statistics.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@thomaseichinger thomaseichinger

Labels

Platform: ARM Platform: This PR/issue effects ARM-based platforms Platform: MSP Platform: This PR/issue effects MSP-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Milestone

Release 2014.12

Development

Successfully merging this pull request may close these issues.

cpu: simplify folder structure

4 participants

@OlegHahm @thomaseichinger @LudwigKnuepfer @rousselk