cpu/sam0_eth: fix hang with broken PHY#21172
Merged
dylad merged 1 commit intoRIOT-OS:masterfrom Jan 30, 2025
Merged
Conversation
github-actions
bot
added
Platform: ARM
dylad
reviewed
Jan 29, 2025
benpicco
force-pushed
the
cpu/sam0_common/eth-hang
branch
from
2710783 to
c791ff2
Compare
dylad
added
the
CI: ready for build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
On boards with a broken PHY the init will hang indefinitely.
This is not very nice and makes it hard to tell what's wrong - instead, bail out early if the PHY does not become IDLE at all.
Testing procedure
Issues/PRs references