cpu/sam3: fix PMC enable/disable peripheral clock access#21168
Merged
mguetschow merged 1 commit intoRIOT-OS:masterfrom Jan 28, 2025
Merged
cpu/sam3: fix PMC enable/disable peripheral clock access#21168mguetschow merged 1 commit intoRIOT-OS:masterfrom
mguetschow merged 1 commit intoRIOT-OS:masterfrom
Conversation
Signed-off-by: Dylan Laduranty <[email protected]>
github-actions
bot
added
Platform: ARM
dylad
added
Type: bug
mguetschow
approved these changes
Jan 28, 2025
Contributor
mguetschow
left a comment
mguetschow
left a comment
There was a problem hiding this comment.
Double-checked with the datasheet, looks good. Thanks!
Member
Author
|
Thanks ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR fixes the access of PMC enable/disable peripheral clock.
PMC_PCERxregisters are labelled write-only in SAM3/SAM4S datasheet. Thus writing 0 has no effect. This means we cannot usePCERxto disable a peripheral clock. Instead one must usePCEDxregister to properly disable a peripheral clock.As both registers (enable/disable) are write-only, this PR also drops the read-modify-write for a single write.
Testing procedure
CI should be enough I guess.
Issues/PRs references
None