pkg/driver_cryptocell_310: check for input data to be in RAM#21138
Merged
mguetschow merged 4 commits intoRIOT-OS:masterfrom Jan 29, 2025
Merged
pkg/driver_cryptocell_310: check for input data to be in RAM#21138mguetschow merged 4 commits intoRIOT-OS:masterfrom
mguetschow merged 4 commits intoRIOT-OS:masterfrom
Conversation
mguetschow
requested review from
MichelRottleuthner,
aabadie and
leandrolanzieri
as code owners
mguetschow
requested review from
Einhornhool
and removed request for
MichelRottleuthner,
aabadie and
leandrolanzieri
github-actions
bot
added
Area: tests
mguetschow
force-pushed
the
psa-cc310-dma-check
branch
from
da0e6f4 to
ff6d2f7
Compare
mguetschow
added
the
CI: ready for build
MrKevinWeiss
added
State: waiting for end of feature-freeze
Process: blocked by feature freeze
MrKevinWeiss
removed
the
Process: blocked by feature freeze
Contributor
|
Freeze is over so if anyone wants to pick this up... |
Contributor
|
Looks good to me besides some small issues. But i think we should document this little detail inside the cryptocell documentation so that people using 3rd-party libraries are aware of this. |
Wer-Wolf
reviewed
Jan 28, 2025
Contributor
|
Looks good to me. |
miri64
reviewed
Jan 28, 2025
miri64
reviewed
Jan 28, 2025
Member
|
Please squash |
mguetschow
force-pushed
the
psa-cc310-dma-check
branch
from
9c193ac to
60521a1
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Member
|
Woops, |
mguetschow
force-pushed
the
psa-cc310-dma-check
branch
from
60521a1 to
36aafd4
Compare
Contributor
Author
|
Thanks! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
The nrf CRYPTOCELL peripheral is documented to only support DMA from RAM. In fact, it seems that short data buffers from ROM are also fine (that's why the tests did not catch the bug yet), while larger ones are not.
Let's add an unconditional check for the data to be in RAM following the documentation to be on the safe side.
Testing procedure
examples/psa_cryptoandtests/sys/psa_crypto_*should still succeed onnrf52840dk. Tested locally, weekly CI should notice if not.Let's maybe wait with this one after the hard feature freeze @MrKevinWeiss.
Issues/PRs references
Initially noted during ChaCha20 implementation in #20720 (comment), now run into the same problem with hashes.