gnrc_netif: fix timeout in gnrc_netif_ipv6_wait_for_global_address()#21137
Merged
MrKevinWeiss merged 1 commit intoRIOT-OS:masterfrom Jan 20, 2025
Conversation
benpicco
force-pushed
the
gnrc_netif_ipv6_wait_for_global_address-fix_timeout
branch
from
c5ccefa to
a95bd50
Compare
benpicco
added
the
Type: bug
benpicco
added
the
CI: ready for build
kfessel
reviewed
Jan 16, 2025
Contributor
kfessel
left a comment
kfessel
left a comment
There was a problem hiding this comment.
looks very good to me.
very good use of ztimer -- reducing the number of ztimer_now.
I assume you tested this.
In case I would trust your testing and approve.
| if (ztimer_msg_receive_timeout(ZTIMER_MSEC, &m, timeout_ms) < 0) { | ||
| if (timeout_ms == UINT32_MAX) { | ||
| msg_receive(&m); | ||
| } else if (ztimer_msg_receive_timeout(ZTIMER_MSEC, &m, timeout_ms) < 0) { |
Contributor
There was a problem hiding this comment.
Suggested change
| } else if (ztimer_msg_receive_timeout(ZTIMER_MSEC, &m, timeout_ms) < 0) { | |
| } | |
| else if (ztimer_msg_receive_timeout(ZTIMER_MSEC, &m, timeout_ms) < 0) { |
according to RIOT coding style
Contributor
There was a problem hiding this comment.
since both styles are already in this file, this can be ignored
MrKevinWeiss
approved these changes
Jan 20, 2025
benpicco
deleted the
gnrc_netif_ipv6_wait_for_global_address-fix_timeout
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
The timeout value in
gnrc_netif_ipv6_wait_for_global_address()would overflow for large timeouts, leading to an immediate return.Instead of doing arithmetic, set a proper timer - or don't if the timeout is
UINT32_MAX.Testing procedure
Issues/PRs references