CODING_CONVENTIONS.md: bump minimum Python version#21124
Merged
chrysn merged 2 commits intoRIOT-OS:masterfrom Jan 10, 2025
Merged
CODING_CONVENTIONS.md: bump minimum Python version#21124chrysn merged 2 commits intoRIOT-OS:masterfrom
chrysn merged 2 commits intoRIOT-OS:masterfrom
Conversation
maribu
approved these changes
Jan 9, 2025
maribu
added
the
CI: ready for build
maribu
added
the
Process: needs >1 ACK
github-actions
bot
added
the
Process: missing approvals
Enoch247
approved these changes
Jan 10, 2025
Contributor
Enoch247
left a comment
Enoch247
left a comment
There was a problem hiding this comment.
I have a minor complaint with the spelling correction being unmentioned. This is not enough to prevent my approval though.
Raising the minimum version is only a formality. Several features, such as f-strings are already used in the code base. In addition, the CI builds use a Docker images based on Ubuntu 22.04. Ubuntu 22.04 ships with Python 3.10.
basilfx
force-pushed
the
python-minimum-version
branch
from
56ca58f to
ff20545
Compare
github-actions
bot
removed
the
Process: missing approvals
Minor formatting and spelling corrections in the Python coding convention section.
basilfx
force-pushed
the
python-minimum-version
branch
from
ff20545 to
4e7e28b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Raising the minimum version is only a formality. Several features, such as f-strings are already used in the code base.
In addition, the CI builds use a Docker image based on Ubuntu 22.04. Ubuntu 22.04 ships with Python 3.10.
While at it, I also improved the spelling a bit.
Testing procedure
Not applicable.
Issues/PRs references
None