Skip to content

examples/gnrc_border_router: Request temporary address (IA_NA) for the 6lbr example#21118

Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom
OlegHahm:pr/feature/ia_na_for_6lbr
Feb 5, 2025
Merged

examples/gnrc_border_router: Request temporary address (IA_NA) for the 6lbr example#21118
miri64 merged 1 commit intoRIOT-OS:masterfrom
OlegHahm:pr/feature/ia_na_for_6lbr

Conversation

@OlegHahm
Copy link
Copy Markdown
Member

@OlegHahm OlegHahm commented Jan 2, 2025

Contribution description

Additionally to requesting a delegated prefix via DHCPv6 this also enables to ask for a temporary (non-permanent) address on the 6lbr. If the upstream DHCP server provides one, this can be used to establish end-to-end connectivity from the 6lbr towards an Internet host directly.

Testing procedure

  1. Bridge the upstream interface of the border router to your upstream router (assuming that it does DHCPv6) or configure a local DHCPv6 server, for instance KEA with a configuration like this
  2. Run the border router and check if you can ping Internet hosts directly.

@github-actions github-actions bot added the Area: examples Area: Example Applications label Jan 2, 2025
@OlegHahm OlegHahm force-pushed the pr/feature/ia_na_for_6lbr branch from 11a23b5 to 63e7cc2 Compare January 2, 2025 12:58
@mguetschow mguetschow added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jan 2, 2025
@mguetschow mguetschow requested review from benpicco and miri64 January 2, 2025 14:01
@riot-ci
Copy link
Copy Markdown

riot-ci commented Jan 2, 2025 •
edited
Loading

Murdock results

✔️ PASSED

63a8f46 examples/gnrc_border_router: request temp address

Success Failures Total Runtime
19 0 19 01m:34s

Artifacts

@benpicco
Copy link
Copy Markdown
Contributor

benpicco commented Jan 6, 2025

I don't understand why this is needed - with my Fritz!Box SLAAC works just fine

@OlegHahm
Copy link
Copy Markdown
Member Author

OlegHahm commented Jan 6, 2025

If SLAAC is activated, you don't need this.

@OlegHahm
Copy link
Copy Markdown
Member Author

OlegHahm commented Jan 28, 2025

Is there a reason against this patch? Should we make this optionally (via a Makefile switch)?

@miri64
Copy link
Copy Markdown
Member

miri64 commented Jan 28, 2025

Is there a reason against this patch? Should we make this optionally (via a Makefile switch)?

I don't see any reason against it. And for once, I don't think a makefile switch here is necessary (except if the user wants to safe ROM on the BR for some reason... but hey it's a BR...) @benpicco?

@benpicco
Copy link
Copy Markdown
Contributor

benpicco commented Jan 29, 2025

Does this still work if the server only does IA_PD and not IA_NA?
I can test this evening on my Fritz!Box if you want.

@miri64
Copy link
Copy Markdown
Member

miri64 commented Jan 29, 2025 •
edited
Loading

Does this still work if the server only does IA_PD and not IA_NA?
I can test this evening on my Fritz!Box if you want.

If it does not, I would count that as a bug (in our DHCPv6 client). Sure, we can postpone the PR because of that, but then we also fix it ;-).

@benpicco
Copy link
Copy Markdown
Contributor

benpicco commented Jan 29, 2025

yup still working

2025-01-29 20:40:02,385 # Iface  9  HWaddr: 3C:71:BF:9E:13:FD  Channel: 1 
2025-01-29 20:40:02,389 #           L2-PDU:249  MTU:1280  HL:64  RTR  
2025-01-29 20:40:02,393 #           RTR_ADV  6LO  Source address length: 6
2025-01-29 20:40:02,396 #           Link type: wireless
2025-01-29 20:40:02,401 #           inet6 addr: fe80::3e71:bfff:fe9e:13fd  scope: link  VAL
2025-01-29 20:40:02,409 #           inet6 addr: 2001:9e8:1437:50ff:3e71:bfff:fe9e:13fd  scope: global  VAL
2025-01-29 20:40:02,411 #           inet6 group: ff02::2
2025-01-29 20:40:02,414 #           inet6 group: ff02::1
2025-01-29 20:40:02,417 #           inet6 group: ff02::1:ff9e:13fd
2025-01-29 20:40:02,418 #           
2025-01-29 20:40:02,424 # Iface  10  HWaddr: 3C:71:BF:9E:13:FC  Channel: 1  Link: up 
2025-01-29 20:40:02,428 #           L2-PDU:1500  MTU:1492  HL:255  RTR  
2025-01-29 20:40:02,431 #           Source address length: 6
2025-01-29 20:40:02,433 #           Link type: wireless
2025-01-29 20:40:02,439 #           inet6 addr: fe80::3e71:bfff:fe9e:13fc  scope: link  VAL
2025-01-29 20:40:02,446 #           inet6 addr: 2001:9e8:1437:5000:3e71:bfff:fe9e:13fc  scope: global  VAL
2025-01-29 20:40:02,449 #           inet6 group: ff02::2
2025-01-29 20:40:02,451 #           inet6 group: ff02::1
2025-01-29 20:40:02,455 #           inet6 group: ff02::1:ff9e:13fc

benpicco
benpicco reviewed Jan 29, 2025
View reviewed changes
@OlegHahm
examples/gnrc_border_router: request temp address
63a8f46 
Additionally to requesting a delegated prefix via DHCPv6 this also
enables to ask for a temporary (non-permanent) address on the 6lbr. If
the upstream DHCP server provides one, this can be used to establish
end-to-end connectivity from the 6lbr towards an Internet host directly.
@OlegHahm OlegHahm force-pushed the pr/feature/ia_na_for_6lbr branch from 8bb9bac to 63a8f46 Compare January 29, 2025 21:57
@OlegHahm
Copy link
Copy Markdown
Member Author

OlegHahm commented Feb 4, 2025

So, are we good to go?

@miri64 miri64 added this pull request to the merge queue Feb 5, 2025
Merged via the queue into RIOT-OS:master with commit 3445cdc Feb 5, 2025
1 check passed
@miri64 miri64 added the Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation label Feb 5, 2025
@mguetschow mguetschow added this to the Release 2025.04 milestone Apr 8, 2025
@maribu maribu changed the title Request temporary address (IA_NA) for the 6lbr example examples/gnrc_border_router: Request temporary address (IA_NA) for the 6lbr example Apr 28, 2025
@maribu maribu mentioned this pull request Apr 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benpicco benpicco benpicco approved these changes

@miri64 miri64 Awaiting requested review from miri64

Assignees

No one assigned

Labels

Area: examples Area: Example Applications CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

Release 2025.04

Development

Successfully merging this pull request may close these issues.

5 participants

@OlegHahm @riot-ci @benpicco @miri64 @mguetschow