Configure default DNS resolver in 6lbr example#21117
Merged
miri64 merged 2 commits intoRIOT-OS:masterfrom Jan 28, 2025
Merged
Conversation
For convenience, it would be nice to have DNS resolution enabled by default in the examples. Hence, this patch configures a default DNS resolver on the 6lbr example and propagates its via RDNSS option in RAs to the nodes.
mguetschow
added
the
CI: ready for build
miri64
reviewed
Jan 28, 2025
examples/gnrc_border_router/Makefile
Outdated
| # to auto-configure that upstream DNS server. | ||
| #USEMODULE += sock_dns # include DNS client | ||
| #USEMODULE += gnrc_ipv6_nib_dns # include RDNSS option handling | ||
| USEMODULE += sock_dns # include DNS client |
Member
There was a problem hiding this comment.
Suggested change
| USEMODULE += sock_dns # include DNS client | |
| USEMODULE += dns_cache # cache DNS responses | |
| USEMODULE += sock_dns # include DNS client |
Member
There was a problem hiding this comment.
Also, I think here too some ENABLE_DNS ?= 1 switch or something of the like would be helpful, in case e.g. you don't want the border router include RDNSS options in its RAs (e.g. to prevent RA fragmentation).
Member
Author
There was a problem hiding this comment.
I tried to address both comments in my latest commit.
Introduces two Makefile switches for enabling DNS resolution and caching.
miri64
approved these changes
Jan 28, 2025
Member
miri64
left a comment
miri64
left a comment
There was a problem hiding this comment.
Untested ACK, but this just adds modules so any issue should be picked up by the CI.
miri64
added
the
Type: enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
For convenience, it would be nice to have DNS resolution enabled by default in the examples. Hence, this patch configures a default DNS resolver on the 6lbr example and propagates its via RDNSS option in RAs to the nodes.
Once again the tradeoff is some increased ROM and RAM usage.
Testing procedure
BOARD=nrf52840dongle make -C examples/gnrc_border_router clean all flash ULINK=cdc-ecm.gnrc_networkingwhile enablingUSEMODULE += sock_dnsandUSEMODULE += gnrc_ipv6_nib_dns.ping riot-os.org.Issues/PRs references
Can be tested with #21116.