pkg/lwip: fix adaption to API change of netdev_new_api#21091
Merged
benpicco merged 1 commit intoRIOT-OS:masterfrom Dec 16, 2024
Merged
pkg/lwip: fix adaption to API change of netdev_new_api#21091benpicco merged 1 commit intoRIOT-OS:masterfrom
benpicco merged 1 commit intoRIOT-OS:masterfrom
Conversation
github-actions
bot
added
Area: network
maribu
added
Type: bug
maribu
force-pushed
the
pkg/lwip/adapt-to-netdev_new_new_api
branch
2 times, most recently
from
0fb00bd to
04589cd
Compare
Member
Author
|
I tested again after the last force push, still works as before. I originally assumed that this was just not adapted to the new API; it was, but just a few lines where it should have come. |
maribu
changed the title
Since RIOT-OS#21012 a netdev in the new API can return > 0 directly in netdev_driver_t::send() to indicate the driver is naturally synchronous and has already completed the transmission. The adaption of lwIP to that API change contained a bug: It handled the case after the thread is already blocked waiting for the signal that is never going to arrive. This is now fixed.
maribu
force-pushed
the
pkg/lwip/adapt-to-netdev_new_new_api
branch
from
04589cd to
424eae0
Compare
Member
Author
|
And another force-push: Rewording the commit title. (No retesting required, as no code changed.) |
Contributor
|
You can also drop the |
Member
Author
|
It could be set to an error other than RIOT/pkg/lwip/contrib/netdev/lwip_netdev.c Line 312 in 424eae0 |
benpicco
approved these changes
Dec 16, 2024
Member
Author
|
Thx 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Since #21012 a netdev in the new API can return > 0 directly in netdev_driver_t::send() to indicate the driver is naturally synchronous and has already completed the transmission.
The adaption of lwIP to that API change contained a bug: It handled the case after the thread is already blocked waiting for the signal that is never going to arrive. This is now fixed.
Testing procedure
In
masterThis PR
Issues/PRs references
#21012