sys/chunked_ringbuffer: discard stale chunk when starting a new one#21073
Merged
maribu merged 2 commits intoRIOT-OS:masterfrom Dec 14, 2024
Merged
sys/chunked_ringbuffer: discard stale chunk when starting a new one#21073maribu merged 2 commits intoRIOT-OS:masterfrom
maribu merged 2 commits intoRIOT-OS:masterfrom
Conversation
mguetschow
reviewed
Dec 11, 2024
Contributor
mguetschow
left a comment
mguetschow
left a comment
There was a problem hiding this comment.
Is that really expected behavior? An alternative would be to return an error upon adding a chunk while the previous has not been ended.
At least, the implemented behavior should be documented somewhere.
benpicco
force-pushed
the
sys/chunked_ringbuffer-start_discard
branch
from
d2d46bb to
3d16d4b
Compare
benpicco
force-pushed
the
sys/chunked_ringbuffer-start_discard
branch
from
3d16d4b to
50b7467
Compare
Contributor
Author
|
I updated the documentation. |
benpicco
added
the
CI: ready for build
mguetschow
reviewed
Dec 13, 2024
benpicco
force-pushed
the
sys/chunked_ringbuffer-start_discard
branch
from
72d4d76 to
532f018
Compare
mguetschow
approved these changes
Dec 13, 2024
Contributor
mguetschow
left a comment
mguetschow
left a comment
There was a problem hiding this comment.
Thanks, looks good to me now!
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
If there is a non-finished chunk in the ringbuffer when a new one is started, discard the stale chunk first.
Testing procedure
The unit test is expanded to cover this case.
Issues/PRs references