Currently the color_rgb_ts get converted to rmt_item32_ts at every write operation. As far as I understand, if we could avoid this conversion at every write, we could have the RMT driver do writes without blocking, and this would yield a better speedup.

Could be done by having ws281x_set_buffer to write to its buffer in the form of a rmt_item32_t instead of color_rgb_t, at least for the esp32 that uses the RMT.

Do the ESP gurus here see anything wrong with this potential solution?

The code change looks good to me. Do you happen to already have tested that this doesn't cause any regressions? (Not that I would expect any from the changes, but better safe than sorry.)

Otherwise I can give the code a spin.

Do you happen to already have tested that this doesn't cause any regressions?

I'v been running it yes. So far so good.

Otherwise I can give the code a spin.

That would give me more confidence.

as far as i understand, this change would affect someone's application only if they change clock frequency in run time.

with this change in, should someone do such thing, they would have to deinit and reinit the neopixel driver.

Murdock results

✔️ PASSED

53a4a8a drivers/ws281x: esp32 neopixel driver to set the rmt symbol data structures at init instead of every write

Artifacts

• Documentation preview