makefiles: select default prng _after_ recursive dependency resolution#21060
Merged
maribu merged 2 commits intoRIOT-OS:masterfrom Dec 3, 2024
Merged
makefiles: select default prng _after_ recursive dependency resolution#21060maribu merged 2 commits intoRIOT-OS:masterfrom
maribu merged 2 commits intoRIOT-OS:masterfrom
Conversation
mguetschow
requested review from
MichelRottleuthner,
aabadie and
leandrolanzieri
as code owners
github-actions
bot
added
Area: doc
mguetschow
added
the
CI: ready for build
maribu
approved these changes
Dec 2, 2024
Member
maribu
left a comment
maribu
left a comment
There was a problem hiding this comment.
lgtm.
If you would reorder the commits (first the fix than the test) every commit would paas the CI, which is nice for bisecting. But that is purely optional.
maribu
approved these changes
Dec 2, 2024
Member
maribu
left a comment
maribu
left a comment
There was a problem hiding this comment.
lgtm.
If you would reorder the commits (first the fix than the test) every commit would paas the CI, which is nice for bisecting. But that is purely optional.
mguetschow
force-pushed
the
make-random-prng-default
branch
from
71fbb66 to
d5783d7
Compare
Contributor
Author
|
Reordered the commits as proposed :) |
mguetschow
force-pushed
the
make-random-prng-default
branch
from
d5783d7 to
9f2755a
Compare
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
The PRNG is supposed to be set only if there is none selected at the end of the recursive dependency resolution. However, this is currently not the case: a transitive dependency setting the PRNG (encountered with
psa_cryptowhich selectsprng_sha256prng) will lead to a user-facing dependency clash.The first commit extends
tests/build_system/external_moduleto showcase the issue and the second one fixes it by moving the automatic prng selection todefaultmodules_deps.inc.mk.Disclaimer: I'm not sure if this is the right approach to follow, but it seems to work. Any suggestions from people with more insights on the build system are welcome.
Testing procedure
with only the first commit:
with both commits: