core/msg: re-enable IRQs before printing for highlevel_stdio#21047
Merged
maribu merged 2 commits intoRIOT-OS:masterfrom Nov 28, 2024
Merged
core/msg: re-enable IRQs before printing for highlevel_stdio#21047maribu merged 2 commits intoRIOT-OS:masterfrom
maribu merged 2 commits intoRIOT-OS:masterfrom
Conversation
github-actions
bot
added
the
Area: core
miri64
requested changes
Nov 26, 2024
Member
miri64
left a comment
miri64
left a comment
There was a problem hiding this comment.
There is output on nrf52840dongle now for this test, but compared to master on native the numbers appear to be random.
maribu
reviewed
Nov 26, 2024
maribu
reviewed
Nov 26, 2024
maribu
reviewed
Nov 26, 2024
benpicco
reviewed
Nov 27, 2024
mguetschow
requested review from
MichelRottleuthner,
aabadie and
leandrolanzieri
as code owners
maribu
approved these changes
Nov 27, 2024
Member
maribu
left a comment
maribu
left a comment
There was a problem hiding this comment.
The CI has a nitpick. Please squash at will
Contributor
Author
|
I've changed the test to also check the msg_queue copying in other cases and it works at least on |
mguetschow
force-pushed
the
msg-queue-print
branch
from
394d510 to
6fed8ec
Compare
benpicco
added
the
CI: ready for build
miri64
reviewed
Nov 28, 2024
copy message queue information to stack before
mguetschow
force-pushed
the
msg-queue-print
branch
from
24dfd83 to
e843514
Compare
Contributor
Author
|
Thanks all! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
highlevel_stdio such as usb-cdc-acm seems to require IRQs to be enabled for printing, but
msg_queue_print()currently prints with IRQs disabled. This PR fixes that by copying the message queue information to the stack before re-enabling IRQs.Testing procedure
make -C tests/core/msg_queue_print BOARD=feather-nrf52840-sense flash testhangs on
master, passes with this PRChanges tested on
nativeandseeedstudio-xiao-nrf52840.Issues/PRs references
Encountered while testing for #20980.