check_in_readme.sh: tell dev _which_ README.md#21044
Merged
mguetschow merged 1 commit intoRIOT-OS:masterfrom Nov 26, 2024
Merged
check_in_readme.sh: tell dev _which_ README.md#21044mguetschow merged 1 commit intoRIOT-OS:masterfrom
mguetschow merged 1 commit intoRIOT-OS:masterfrom
Conversation
AnnsAnns
approved these changes
Nov 26, 2024
Member
AnnsAnns
left a comment
AnnsAnns
left a comment
There was a problem hiding this comment.
Nice catch, I can see how that could be confusing 👍
mguetschow
added
the
CI: ready for build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
I was a bit confused that the static tests were asking me to add the example to
README.mdbut not telling me whichREADME.md(so I assumed the one in root..., which did not fix it...). So here is my proposal to fix it.Testing procedure
@AnnsAnns' approval?
Issues/PRs references
Follow-up on #20957.