cpu/sam0_common: flashpage: disable cache while writing#21043
Merged
dylad merged 2 commits intoRIOT-OS:masterfrom Dec 15, 2024
Merged
cpu/sam0_common: flashpage: disable cache while writing#21043dylad merged 2 commits intoRIOT-OS:masterfrom
dylad merged 2 commits intoRIOT-OS:masterfrom
Conversation
fix errata 2.14.1: NVM Read Corruption
github-actions
bot
added
Platform: ARM
Member
|
Does this PR also affect SAML1X ? |
maribu
approved these changes
Nov 26, 2024
Contributor
|
You told me about the errata and I would be happy to have the interrupts enabled again. |
maribu
added
the
CI: ready for build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
From errata 2.14.1:
Testing procedure
I ran
examples/suit_updateonsame54-xpro.This would previously crash when not disabling the interrupts.
I also tested this on
samr34-xproto ensure no regressions onsaml21.samd21never needed the disabled interrupts in the first place.Issues/PRs references