drivers/at86rf215: return ENETDOWN when interface is down#21031
Merged
maribu merged 4 commits intoRIOT-OS:masterfrom Nov 23, 2024
Merged
drivers/at86rf215: return ENETDOWN when interface is down#21031maribu merged 4 commits intoRIOT-OS:masterfrom
maribu merged 4 commits intoRIOT-OS:masterfrom
Conversation
benpicco
requested review from
MichelRottleuthner,
PeterKietzmann,
aabadie,
leandrolanzieri and
miri64
as code owners
github-actions
bot
added
Area: network
benpicco
force-pushed
the
net_fixes-misc
branch
from
261cdac to
9d22e46
Compare
benpicco
added
the
Type: bug
benpicco
added
the
CI: ready for build
maribu
reviewed
Nov 22, 2024
maribu
reviewed
Nov 22, 2024
maribu
approved these changes
Nov 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
We would return EBUSY when the interface was in sleep, this caused the gnrc_netif to retry sending forever. Return ENETDOWN instead.
I added three additional minor fixes to this to not bother CI with those trivial changes:
gnrc_netifto tell apart the case where a pkt can't be queued and is dropped and where we try sending it insteadtx_frame_lenthat has already been set inat86rf215_tx_load()Testing procedure
Issues/PRs references