tests/core/cond_order/: calling cond signal and broadcast without waiting threads#21030
Merged
maribu merged 1 commit intoRIOT-OS:masterfrom Nov 26, 2024
Merged
Conversation
JulianHolzwarth
requested review from
MichelRottleuthner,
aabadie and
leandrolanzieri
as code owners
benpicco
added
the
CI: ready for build
mguetschow
approved these changes
Nov 25, 2024
Contributor
mguetschow
left a comment
mguetschow
left a comment
There was a problem hiding this comment.
Thanks, LGTM! I'll trust CI for testing.
Member
|
I toggled the merge queue to prevent a timeout. The nightly build is still in front of this PR, but is done in about 2h. So this should pass now before the 360 min timeout is hit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Through test coverage, I noticed the test never tried the functions
cond_signalandcond_broadcastwithout a thread waiting. This change helps to find problems with the functions when no thread is waiting.Testing procedure
BOARD=native make -C tests/core/cond_order flash testcheck test coverage before and after (I used simple coverage of thread communication)