Skip to content

tests: make embUnit a normal sys module#2102

Merged
LudwigKnuepfer merged 2 commits intoRIOT-OS:masterfrom
Kijewski:embunit-module
Dec 22, 2014
Merged

tests: make embUnit a normal sys module#2102
LudwigKnuepfer merged 2 commits intoRIOT-OS:masterfrom
Kijewski:embunit-module

Conversation

@Kijewski
Copy link
Copy Markdown
Contributor

There is nothing quite special about embUnit.

This PR makes it a normal sys module, so that you can use it in any
application / test.

@Kijewski Kijewski added the Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation label Nov 27, 2014
@OlegHahm
Copy link
Copy Markdown
Member

Can you think of any use case for that?

@Kijewski
Copy link
Copy Markdown
Contributor Author

I guess the prime answer would be: Writing unit tests for your applications that you don't want to merge into master.

But more important for me was that this change makes the embUnit "module" less of a special case. E.g. there's no more a reference to embUnit in Makefile.application.

@miri64
Copy link
Copy Markdown
Member

miri64 commented Nov 28, 2014

I fear a little bit that we then get unittest applications galore, while the current design enforces developer to centralize them in the 'tests/unittests' application.

@LudwigKnuepfer
Copy link
Copy Markdown
Member

@authmillenon I'm not afraid of that.

@miri64
Copy link
Copy Markdown
Member

miri64 commented Nov 28, 2014

If you tell me then every time I like to test a module where to find its unittests ;)

@miri64
Copy link
Copy Markdown
Member

miri64 commented Nov 28, 2014

@Kijewski since you've made some crucial changes to embunit: should we present them to upstream?

@LudwigKnuepfer
Copy link
Copy Markdown
Member

I didn't mean I wasn't afraid of the results of unittest fragmentation, I am not afraid the fragmentation is going to occur because we have this review process.

@LudwigKnuepfer
Copy link
Copy Markdown
Member

(And we also have documentation on how to write unittests and we already have a centralized structure which will provoke it's continued usage.)

@miri64
Copy link
Copy Markdown
Member

miri64 commented Nov 28, 2014

(Because the review process is always perfect ;-))

@LudwigKnuepfer
Copy link
Copy Markdown
Member

I'm glad you see it that way ;)

@miri64 miri64 added this to the Release NEXT MAJOR milestone Nov 28, 2014
@Kijewski
Copy link
Copy Markdown
Contributor Author

Nevermind if users should use this module or not. This PR removes the ugly special cases in for embUnit in Makefile.application.

@LudwigKnuepfer
Copy link
Copy Markdown
Member

@authmillenon do you NACK this? If not please say so.

@miri64
Copy link
Copy Markdown
Member

miri64 commented Dec 11, 2014

No... Go on if you must ;)

@LudwigKnuepfer
Copy link
Copy Markdown
Member

@Kijewski I assume you are unwilling to fix the doxygen warnings?

@Kijewski
Copy link
Copy Markdown
Contributor Author

I assume you are unwilling to fix the doxygen warnings?

For now, yes. :)

@LudwigKnuepfer
Copy link
Copy Markdown
Member

In file included from /home/ludwig/RIOT/tests/unittests/tests-bloom/tests-bloom.c:12:0:
/home/ludwig/RIOT/tests/unittests/tests-bloom/tests-bloom.h:21:26: fatal error: ../unittests.h: No such file or directory
 #include "../unittests.h"
                          ^
compilation terminated.

@LudwigKnuepfer
Copy link
Copy Markdown
Member

(needs rebase)

There is nothing quite special about embUnit.

This PR makes it a normal sys module, so that you can use it in any
application / test.
@Kijewski
Copy link
Copy Markdown
Contributor Author

rebased

@LudwigKnuepfer
Copy link
Copy Markdown
Member

ACK & go

LudwigKnuepfer pushed a commit that referenced this pull request Dec 22, 2014
tests: make embUnit a normal sys module
@LudwigKnuepfer LudwigKnuepfer merged commit dc916ad into RIOT-OS:master Dec 22, 2014
@Kijewski Kijewski deleted the embunit-module branch December 22, 2014 12:53
@miri64 miri64 mentioned this pull request Jan 14, 2015
@OlegHahm OlegHahm modified the milestone: Release 2015.12 Dec 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants