boards/stm32f429i-disc1: fix touch screen axis [backport 2024.10]#21014
Merged
maribu merged 1 commit intoRIOT-OS:2024.10-branchfrom Nov 21, 2024
Merged
Conversation
This patch fixes a missmatch between the LCD and touch drivers' coordinate systems. (cherry picked from commit 05bc405)
benpicco
added
Area: boards
Enoch247
approved these changes
Nov 21, 2024
Contributor
Enoch247
left a comment
Enoch247
left a comment
There was a problem hiding this comment.
Looks good. Tested on my board and it works.
Contributor
|
I haven't merged many PRs yet. Should I merge this? Any special instructions? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #21007
Contribution description
This patch fixes a missmatch between the LCD and touch drivers' coordinate systems.
Testing procedure
Build and flash with
make -C tests/pkg/lvgl_touch/ flash, and observe the test works as intended with this patch, but not without it.Issues/PRs references
none known