tests/periph/selftest_shield: fix invalid calls to timer_init() + GPIO IRQ tests#21006
Merged
maribu merged 2 commits intoRIOT-OS:masterfrom Nov 21, 2024
Merged
Conversation
maribu
added
Type: enhancement
maribu
requested review from
MichelRottleuthner,
aabadie and
leandrolanzieri
as code owners
maribu
force-pushed
the
tests/periph/selftest_shield/fix-timer_init
branch
from
6483bc2 to
c60f128
Compare
maribu
changed the title
maribu
changed the title
maribu
added
Type: bug
Member
Author
Calling `timer_init()` with unsupported frequencies on some MCUs just selects the closest possible frequency. But e.g. on SAM0, using an unsupported frequency will cause `timer_init()` to fail; which probably is the better option. However, a failing calling to `timer_init()` results in a test failure. This is now worked around by using timer_query_freq() to select a suitable timer frequency that is supported.
The GPIO IRQ tests had a side-effect that IRQs remained configured after the test case was complete. This caused stray IRQs to trigger on SAM0 MCUs and they consequently (and incorrectly) failed the test.
maribu
force-pushed
the
tests/periph/selftest_shield/fix-timer_init
branch
from
9f21639 to
fd30434
Compare
benpicco
approved these changes
Nov 20, 2024
Member
Author
|
Thx :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Regarding Invalid Calls to
timer_init()Calling
timer_init()with unsupported frequencies on some MCUs just selects the closest possible frequency. But e.g. on SAM0, using an unsupported frequency will causetimer_init()to fail; which probably is the better option.However, a failing calling to
timer_init()results in a test failure. This is now worked around by using timer_query_freq() to select a suitable timer frequency that is supported.Regarding GPIO IRQ Tests
The GPIO IRQ tests had a side-effect that IRQs remained configured after the test case was complete. This caused stray IRQs to trigger on SAM0 MCUs and they consequently (and incorrectly) failed the test.
Testing procedure
On e.g.
wemos-zeroorarduino-zerothe test should now run to completion and - with the exception of the ADC tests - pass.In
masterGPIO IRQ tests will fail and the test will abort after a failing call totimer_init().Issues/PRs references
None