gnrc_netif: netdev_new_api implies TX end irq, no need to check it#20993
Merged
maribu merged 5 commits intoRIOT-OS:masterfrom Nov 17, 2024
Merged
gnrc_netif: netdev_new_api implies TX end irq, no need to check it#20993maribu merged 5 commits intoRIOT-OS:masterfrom
maribu merged 5 commits intoRIOT-OS:masterfrom
Conversation
github-actions
bot
added
Area: network
benpicco
added
CI: ready for build
maribu
approved these changes
Nov 14, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
netdev_new_apiimplies a TX_COMPLETE event, so no need to check for itTX_COMPLETEevents behind aMODULE_NETDEV_LEGACY_APIcheck so they are not used by accident when porting a driver to the new API.Testing procedure
NETOPT_TX_END_IRQ not implemented by drivershould go away withnetdev_new_apionce and for all - the TX_COMPLETE event is now mandated.Issues/PRs references