cpu/nrf52/radio/nrf802154: fix beacon acceptance#20982
cpu/nrf52/radio/nrf802154: fix beacon acceptance#20982mguetschow merged 2 commits intoRIOT-OS:masterfrom
Conversation
|
It looks like this is your first Pull Request? It looks very good for a first PR :) You can perform these static tests on your local machine before publishing a Pull Request (however this is no guarantuee that the tests here won't fail. Sometimes something slips though and that's okay :) ). I'll try to give this a try next week. However I don't know much about 802.15.4. For the test program, it might be good to add one or two commands to send frames without PAN ID or with a mismatched PAN ID to see if the code you added will correctly handles these cases (even though they shouldn't occur in the first place). |
2db3125 to
6f69f03
Compare
|
I tested the PR today and everything works as expected. My only two remaining remarks are:
|
mguetschow
left a comment
There was a problem hiding this comment.
Tested and confirmed to work locally.
Just some small nitpicks below.
@crasbe I think your two comments have been addressed, right?
Yes 👍 |
mguetschow
left a comment
There was a problem hiding this comment.
Perfect, then please squash so we can merge!
d428629 to
a582339
Compare
|
Congratz on your first merged PR, @Lukas-Luger 🎉 |
Contribution description
The nrf802154_radio.c file implements a frame filter on the MAC sublayer as mentioned in IEEE 802.15.4-2020 in Section 6.7.2 Reception and rejection. For beacon frames (section e), it should check if source PAN ID matches the PAN ID of the device. This is currently not the case and beacon frames get filtered out.
This PR implements the PAN ID check, while also confirming that source PAN ID is present in the first place.
Testing procedure
Tests provided in the first commit. (requires two nrf52 devices)
Issues/PRs references